Sync addons-source@maintenance/gramps60 with upstream (2026-06-30)#58
Sync addons-source@maintenance/gramps60 with upstream (2026-06-30)#58eduralph wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ac51fa96e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| r'(?P<nad>SE/\w+/\d+/[^,]+)\s*' | ||
| r'\((?P<years>\d{4}(?:-\d{4})?)\),\s*' | ||
| r'bildid[^_]*_(?P<bildid>\d+)' | ||
| r'(?P<nad>[^\(]+)*' |
There was a problem hiding this comment.
With the new * quantifier, a Riksarkivet-like string that omits the NAD, such as Foo, Bar, (1833-1840), now matches this regex with nad set to None; the following match.group("nad").strip() then raises before the click handler's transaction try block, so the gramplet crashes instead of reporting “Could not parse the reference string.” Keep this group mandatory or explicitly reject a missing NAD before stripping it.
Useful? React with 👍 / 👎.
eduralph
force-pushed
the
sync/upstream-maintenance-gramps60-auto
branch
7 times, most recently
from
7bb7ae8 to
7cd2e99
Compare
eduralph
force-pushed
the
sync/upstream-maintenance-gramps60-auto
branch
from
7cd2e99 to
79ae072
Compare
1 participant
Automated nightly sync from
gramps-project/addons-source@maintenance/gramps60. Generated by .github/workflows/upstream-sync.yml on the testbed.