Skip to content

Feature/872 make secret array configurable#881

Merged
ArBridgeman merged 33 commits into
mainfrom
feature/872_make_secret_array_configurable
Jun 23, 2026
Merged

Feature/872 make secret array configurable#881
ArBridgeman merged 33 commits into
mainfrom
feature/872_make_secret_array_configurable

Conversation

@ArBridgeman

@ArBridgeman ArBridgeman commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

closes #872

Checklist

Note: If any of the items in the checklist are not relevant to your PR, just check the box.

For any Pull Request

Is the following correct:

  • the title of the Pull Request?
  • the title of the corresponding issue?
  • there are no other open Pull Requests for the same update/change?
  • that the issue which this Pull Request fixes ("Fixes...") is mentioned?

When Changes Were Made

Did you:

  • update the changelog?
  • update the cookiecutter-template?
  • update the implementation?
  • check coverage and add tests: unit tests and, if relevant, integration tests?
  • update the User Guide & other documentation?
  • resolve any failing CI criteria (incl. Sonar quality gate)?

When Preparing a Release

Have you:

  • thought about version number (major, minor, patch)?
  • checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?

@ArBridgeman ArBridgeman force-pushed the feature/872_make_secret_array_configurable branch from ffdabf7 to 8519890 Compare June 22, 2026 09:53
@ArBridgeman ArBridgeman force-pushed the feature/872_make_secret_array_configurable branch from 27bb385 to c1c867e Compare June 22, 2026 11:11
tkilias
tkilias reviewed Jun 22, 2026
View reviewed changes
Comment thread doc/user_guide/troubleshooting/handle_zizmor_findings.rst Outdated
ckunki
ckunki requested changes Jun 23, 2026
View reviewed changes
Comment thread doc/changes/unreleased.md Outdated
Comment thread doc/user_guide/features/github_workflows/index.rst Outdated
Comment thread doc/user_guide/features/github_workflows/index.rst Outdated
Comment thread doc/user_guide/troubleshooting/handle_zizmor_findings.rst Outdated
Comment thread exasol/toolbox/util/workflows/custom_workflow.py Outdated
@sonarqubecloud

sonarqubecloud Bot commented Jun 23, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ArBridgeman ArBridgeman merged commit 23d9201 into main Jun 23, 2026
42 checks passed
@ArBridgeman ArBridgeman deleted the feature/872_make_secret_array_configurable branch June 23, 2026 09:34
jana-selva pushed a commit that referenced this pull request Jun 23, 2026
@ArBridgeman @jana-selva
Feature/872 make secret array configurable (#881)
15e0fe3 
* Remove as no secret needed here

* Add initial slow-checks secret modifier

* Switch to supporting multiple customizations

* Switch example as secrets allowed

* Add unit test for CustomWorkflowSecrets

* Add comment

* Update tests to include checking when has the jinja secrets

* Add documentation for new feature

* Alphabetize by name

* Add missing needed block

* Update documentation

* Add changelog entry

* Run format:fix

* Make get_standard_yaml a separate function and extract parse_yaml_text out and use instead

* Add custom workflow class which loads a file and can extract secrets from it

* Add docstring to classes to distinguish

* Add custom_workflow_extractor

* Update workflows to use custom_workflows as source

* Run format:fix

* Improve typing

* Remove CustomWorkflowSecrets from docs as changed and not part of external API

* Make clear it's a major release due to `all-extras`

* Update unreleased.md to latest implementation

* Update unreleased.md so summary is more substantial and accurate

* Update workflow_variables.rst to new implementation

* Overhaul documentation to be clearer and link to each other

* Apply wording improvements

* Fix wording. We really don't 'manage' custom workflows

* Update example to make sense

* Add one more entry to summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkilias tkilias tkilias left review comments

@ckunki ckunki ckunki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make secret arrays configurable for select workflows

3 participants

@ArBridgeman @tkilias @ckunki