ci+build: GitHub Actions CI, R8/resource shrinking (−82% APK), more unit tests#10
ci+build: GitHub Actions CI, R8/resource shrinking (−82% APK), more unit tests#10fabiodalez-dev wants to merge 1 commit into
Conversation
…t tests - CI: add .github/workflows/android-ci.yml — on every PR/push to main it runs unit tests, Android lint, and assembleDebug on JDK 21 with Gradle caching, and uploads test/lint reports. The repo had no CI before. - Release build: enable R8 (`isMinifyEnabled`) + `isShrinkResources`. The keep rules for Retrofit/OkHttp/kotlinx.serialization/Coil/Room already lived in proguard-rules.pro; `assembleRelease` now runs R8 cleanly and the APK drops from ~24 MB (debug) to ~4.3 MB (−82%). A minified release should still get one device smoke-test before shipping (reflection breakage only shows at runtime). - Tests: add DateFormatTest (8 cases) for the locale/zone-aware date formatting used in loans/profile/notifications — em-dash on empty, raw passthrough on parse failure, formatted output otherwise. Full unit suite: 37 green. Verified: assembleRelease (R8) builds; testDebugUnitTest 37/37 green.
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
- #11 CatalogSyncWorker: retry only TRANSIENT failures; give up (success) on permanent ones (401/403/app_disabled/validation/not_found) so the periodic chain isn't stuck retrying an unrecoverable condition. Classification is a pure isPermanentFailure() so it's unit-testable without Android/Hilt. - #13 CatalogSyncWorkerTest: rewritten — the old 'no-op on plain context' test was written for the pre-Hilt (ServiceLocator) worker and broke under #14's EntryPointAccessors migration. Now covers the real branch (permanent vs transient) via the pure function. - #9 HomeViewModel: don't flip loading=false on an empty cache emission — keep the skeleton until the first refresh resolves, so a cold start no longer flashes the 'empty library' state while the network is in flight. - #10 CI: build the release variant too (assembleRelease) so R8/minify is exercised in CI, not only at runtime. Merged the 7-PR stack (#8 navbar/reserve, #9 offline cache, #10 CI/R8, #11 WorkManager sync, #12 Sentry, #13 tests, #14 Hilt) into main; the libs.versions.toml conflict (#13 work-testing vs #14 Hilt libs) resolved as a union. Full build green: 67 unit tests, assembleDebug + assembleRelease.
1 participant
First of a series of "make the app production-grade" changes. Stacked on #9 (offline cache) — base is
feat/offline-catalog-cache; retarget tomainonce #9 merges.What
.github/workflows/android-ci.yml: on every PR/push tomainit runs unit tests + Android lint +assembleDebugon JDK 21 with Gradle caching, and uploads reports. The repo had no CI before.isMinifyEnabled = true+isShrinkResources = truefor release. Keep rules already existed inproguard-rules.pro;assembleReleaseruns R8 cleanly and the APK drops 24 MB → 4.3 MB (−82%).DateFormatTest(8 cases) for the locale/zone-aware date formatting. Full unit suite now 37 green.Verified
assembleRelease(R8 + shrink) builds; release APK 4.3 MB.testDebugUnitTest37/37 green.Note
A minified release should get one device/emulator smoke-test (login → catalog → loan request) before shipping — reflection-based runtime breakage can't be caught at build time.