fix: CodeRabbit round 2 — scope the insecure-HTTP probe flag + accessible toggle row

app/src/main/java/com/pinakes/app/data/repository/AuthRepository.kt

@@ -30,26 +30,34 @@ class AuthRepository(
      * to continue based on [HealthPayload.appAccessEnabled] and the transport warning.
      */
     suspend fun discover(rawInstanceUrl: String, allowInsecure: Boolean = false): ApiResult<HealthDiscovery> {
-        // Carry the onboarding toggle into the cleartext gate: the instance isn't committed
-        // yet, so the persisted flag is still false and would block a plain-HTTP probe.
+        // Carry the onboarding toggle into the cleartext gate ONLY for the duration of this
+        // probe: the instance isn't committed yet, so the persisted flag is still false and
+        // would block a plain-HTTP health check. The NetworkModule OkHttp client is a shared
+        // singleton, so the flag is reset in finally() — otherwise a toggle-on discovery that
+        // fails or is abandoned would leave cleartext allowed for every later request. On a
+        // successful connect, commitInstance() persists the real per-instance flag.
         session.pendingAllowInsecureHttp = allowInsecure
-        val apiBaseUrl = NetworkModule.deriveApiBaseUrl(rawInstanceUrl, allowInsecure)
-        val origin = NetworkModule.deriveOrigin(rawInstanceUrl, allowInsecure)
-        val api = network.api(apiBaseUrl)
-        return when (val res = apiCall { api.health() }) {
-            is ApiResult.Success -> ApiResult.Success(
-                HealthDiscovery(
-                    health = res.data,
-                    origin = origin,
-                    apiBaseUrl = apiBaseUrl,
-                    insecureTransport = res.meta?.warning == "insecure_transport" ||
-                        res.meta?.https == false,
-                    transportAllowed = NetworkModule.isTransportAllowed(apiBaseUrl, allowInsecure),
-                    allowInsecure = allowInsecure,
-                ),
-                res.meta,
-            )
-            is ApiResult.Failure -> res
+        try {
+            val apiBaseUrl = NetworkModule.deriveApiBaseUrl(rawInstanceUrl, allowInsecure)
+            val origin = NetworkModule.deriveOrigin(rawInstanceUrl, allowInsecure)
+            val api = network.api(apiBaseUrl)
+            return when (val res = apiCall { api.health() }) {
+                is ApiResult.Success -> ApiResult.Success(
+                    HealthDiscovery(
+                        health = res.data,
+                        origin = origin,
+                        apiBaseUrl = apiBaseUrl,
+                        insecureTransport = res.meta?.warning == "insecure_transport" ||
+                            res.meta?.https == false,
+                        transportAllowed = NetworkModule.isTransportAllowed(apiBaseUrl, allowInsecure),
+                        allowInsecure = allowInsecure,
+                    ),
+                    res.meta,
+                )
+                is ApiResult.Failure -> res
+            }
+        } finally {
+            session.pendingAllowInsecureHttp = false
         }
     }
 

app/src/main/java/com/pinakes/app/ui/screens/onboarding/OnboardingScreen.kt

@@ -2,6 +2,7 @@ package com.pinakes.app.ui.screens.onboarding
 
 import androidx.compose.foundation.Image
 import androidx.compose.foundation.isSystemInDarkTheme
+import androidx.compose.foundation.selection.toggleable
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Row
@@ -32,6 +33,7 @@ import androidx.compose.ui.draw.clip
 import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.semantics.Role
 import androidx.compose.ui.text.style.TextAlign
 import androidx.compose.ui.unit.dp
 import com.pinakes.app.R
@@ -107,7 +109,15 @@ fun OnboardingScreen(onContinue: () -> Unit) {
 
             if (state.discovery == null) {
                 Row(
-                    modifier = form,
+                    // Toggle from the whole row (not just the switch): a screen reader
+                    // announces the label together with the on/off state, and the larger
+                    // touch target is easier to hit. onCheckedChange = null makes the Switch
+                    // a passive indicator of the row's toggle state.
+                    modifier = form.toggleable(
+                        value = state.allowInsecureHttp,
+                        role = Role.Switch,
+                        onValueChange = vm::onAllowInsecureChange,
+                    ),
                     verticalAlignment = Alignment.CenterVertically,
                 ) {
                     Column(Modifier.weight(1f)) {
@@ -125,7 +135,7 @@ fun OnboardingScreen(onContinue: () -> Unit) {
                     Spacer(Modifier.width(Spacing.md))
                     Switch(
                         checked = state.allowInsecureHttp,
-                        onCheckedChange = vm::onAllowInsecureChange,
+                        onCheckedChange = null,
                     )
                 }