qmux: deliver byte events on stream write, with tests + CMake wiring#625
Open
afrind wants to merge 1 commit into
Open
qmux: deliver byte events on stream write, with tests + CMake wiring#625afrind wants to merge 1 commit into
afrind wants to merge 1 commit into
Conversation
QmuxSession::writeLoop dropped the dequeued delivery callback, so the app's ByteEventCallback registration (and any keepalive it held) leaked and onByteEvent never fired. Fire deliveryCallback->onByteEvent after the buffered write is dequeued and written to the wire. Add QmuxSessionTest coverage: - WriteWithByteEventCallback_FiresOnByteEvent: the fix itself. - CloseSession_CancelsQueuedByteEvent: session close cancels a still queued byte event (shutdown -> WriteHandle::cancel -> clear -> onByteEventCanceled) rather than leaking it. Wire the qmux tests into CMake (they were buck-only): - new proxygen/lib/transport/qmux/test/CMakeLists.txt registering all four qmux tests against granular library targets (not the monolithic proxygen target). - new proxygen/lib/http/coro/transport/test/CMakeLists.txt building the TestCoroTransport test util against granular targets. - add_subdirectory(test) hooks in the qmux and coro/transport parents. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QmuxSession::writeLoop dropped the dequeued delivery callback, so the app's ByteEventCallback registration (and any keepalive it held) leaked and onByteEvent never fired. Fire deliveryCallback->onByteEvent after the buffered write is dequeued and written to the wire.
Add QmuxSessionTest coverage:
Wire the qmux tests into CMake (they were buck-only):