fix(core): opt#16
Merged
Merged
Conversation
The staging/fed-staging intake endpoints were hardcoded to an internal IP (http://10.99.1.110:11300) directly in `intakeSites.ts`. Since these constants are publicly exported, the internal IP + plaintext http endpoint leaked into every published `@flashcatcloud/browser-*` artifact. Move the staging endpoints to the existing build-time injection mechanism (`__BUILD_ENV__*` + replace-build-env / webpack DefinePlugin), the same convention already used for SDK_VERSION. Values are read from the INTAKE_SITE_STAGING / INTAKE_SITE_FED_STAGING env vars at build time and default to an empty string, so release artifacts never contain an internal host. Staging remains configurable by setting the env var at build time. Verified: `BUILD_MODE=release` build of @flashcatcloud/browser-core emits `INTAKE_SITE_STAGING = ""` and `grep -r 10.99` over cjs/ and esm/ is clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the build-time env injection with a hardcoded public https host, matching the native SDKs (Android FlashcatSite.STAGING / iOS FlashcatSite.staging both use jira.flashcat.cloud). This keeps the original audit finding resolved (no internal 10.99.x IP, no cleartext http/port) while making staging work out of the box across all builds with zero CI wiring, and keeps the three client SDKs consistent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fiona2016
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.