Skip to content

fix: preserve subscription enabled false#24

Merged
ysyneu merged 1 commit into
mainfrom
codex/fix-subscription-enabled-20260703
Jul 3, 2026
Merged

fix: preserve subscription enabled false#24
ysyneu merged 1 commit into
mainfrom
codex/fix-subscription-enabled-20260703

Conversation

@ysyneu

@ysyneu ysyneu commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make IncidentTriggerSubscriptionUpsertRequest hand-written so enabled=false survives JSON encoding
  • skip the generated duplicate type and regenerate models
  • add regression coverage for the explicit disabled subscription value

Verification

  • make check
  • go test ./... -run TestIncidentTriggerSubscriptionUpsertRequestPreservesDisabledValue -count=1
  • go test ./... -count=1
  • go generate ./...

@ysyneu ysyneu added the bug Something isn't working label Jul 3, 2026
@ysyneu ysyneu merged commit f90c46d into main Jul 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant