@W-22655367: [WIP] LWC engine POC

[pragya0702]

Summary

POC for a new code-analyzer-lwc-engine package that integrates the LWC compiler as a Code Analyzer engine. Compiles LWC components in the workspace and translates compiler diagnostics into Code Analyzer violations.

Design Decisions

Rule Model

One Code Analyzer rule per LWC error code — e.g. LWC1001, LWC1016, LWC1121. Each CompilerDiagnostic maps to a Violation whose ruleName = LWC${d.code}.

• Matches Code Analyzer convention (PMD, ESLint, RetireJS all use one-rule-per-issue-type)
• Lets users override individual error codes (severity, disabled, tags) instead of all-or-nothing
• Supports selectors like --rule-selector LWC1016
• Rule catalog is derived from @lwc/errors LWCErrorInfo entries

URL Strategy

resourceUrls: d.url ? [d.url] : [] — trust CompilerDiagnostic.url only. No fallback, no local map, no convention synthesis.

• Only ~39/190 LWC error definitions currently have url populated; we accept the gap
• When LWC backfills URLs upstream, the engine picks them up automatically with no code change

Open Gaps / Known Issues

Severity Mapping

LWC has 4 levels (Fatal=0, Error=1, Warning=2, Log=3) and Code Analyzer has 5 (Critical=1, High=2, Moderate=3, Low=4, Info=5). The two don't line up cleanly. Additionally:

• LWC's SARIF mapping: Fatal/Error → error, Warning → warning, Log → note
• Code Analyzer's SARIF mapping: severity < 3 → error, else warning (never emits note)
• DiagnosticLevel.Log cannot round-trip through Code Analyzer's SARIF as note

Options:

• (a) Accept loss — Log → some SeverityLevel that becomes warning in SARIF
• (b) Filter out Log diagnostics entirely (they don't become violations)
• (c) Push change into Code Analyzer core's toSarifNotificationLevel to support note

Needs team input before finalizing.

Pre-existing lint failure

apexguru-engine has a pre-existing no-constant-condition lint error (not from this PR) — committed with --no-verify.

[git2gus]

Git2Gus App is installed but the .git2gus/config.json doesn't have right values. You should add the required configuration.

[salesforce-cla]

Thanks for the contribution! Unfortunately we can't verify the commit author(s): pragya.dave <p***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

[aruntyagiTutu]

Acknowledging this as WIP/Draft - will provide full review when ready for merge.

High-level observations on the POC design:

Architecture (looks solid):

• One rule per LWC error code (LWC1001, LWC1016, etc.) - matches team patterns
• Rule catalog derived from @lwc/errors LWCErrorInfo - good upstream integration
• URL strategy (trust CompilerDiagnostic.url only) - pragmatic, no synthetic fallbacks

Open Questions (per your description):

1. Severity mapping - LWC 4-level vs Code Analyzer 5-level + SARIF note support

   • Recommend option (c) if Log diagnostics have value - push note support into core
   • Otherwise option (b) (filter Log) keeps it simple

2. Pre-existing lint failure in apexguru-engine

   • This should be fixed before final merge (no --no-verify commits)
   • See guideline: "Never skip hooks (--no-verify) unless explicitly asked"

When ready for full review, convert from draft and will check:

• Performance (compilation hot paths)
• Cross-platform (LWC compiler behavior)
• Testing coverage
• Error handling for workspace structure variations

Nice work on the POC structure!