Add physical drop target mechanics#565
Draft
freezy wants to merge 8 commits into
Draft
Conversation
Greptile SummaryThis PR adds opt-in advanced drop-target physics. The main changes are:
Confidence Score: 4/5The mechanical reset collision path needs a fix before merging.
VisualPinball.Unity/VisualPinball.Unity/VPT/HitTarget/TargetCollider.cs Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Ball hits mechanical drop target] --> B{Target resetting or settling?}
B -->|Yes| C{Collider role is physical face?}
C -->|Yes| D[Apply powered reset contact]
C -->|No| E[Use passive wall or back-face collision]
B -->|No| F{Collider role is physical face?}
F -->|Yes| G[Apply mechanical face impact]
F -->|No| E
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Ball hits mechanical drop target] --> B{Target resetting or settling?}
B -->|Yes| C{Collider role is physical face?}
C -->|Yes| D[Apply powered reset contact]
C -->|No| E[Use passive wall or back-face collision]
B -->|No| F{Collider role is physical face?}
F -->|Yes| G[Apply mechanical face impact]
F -->|No| E
Reviews (1): Last reviewed commit: "physics: clean up drop target whitespace" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #536.
Summary
Legacy,RothCompatible, andMechanicaldrop-target physics modes while preserving Legacy as the default for existing contentValidation
FlipperApixref warning is pre-existing and unrelatedgit diff --checkRollout notes
Generic Sliding Bladeprofile is explicitly provisional and is not presented as measured real-machine calibration