Use HTTP QUERY instead of PUT for read RPC methods#87
Merged
sharoonthomas merged 1 commit intoJul 13, 2026
Conversation
debdutgoswami
force-pushed
the
move-from-PUT-to-QUERY
branch
2 times, most recently
from
e954801 to
b099221
Compare
debdutgoswami
commented
Jul 13, 2026
| @register_decoder("bytes") | ||
| def _bytes_decoder(v): | ||
| cast = bytearray if bytes == str else bytes | ||
| cast = bytearray if bytes is str else bytes |
Member
Author
There was a problem hiding this comment.
not a stray change. lint failure otherwise
https://github.com/fulfilio/fulfil-python-api/actions/runs/29241106668/job/86787114207?pr=87
Read-oriented RPC calls (search, read, search_read, search_count) need a request body to carry filters and fields, so they were sent as PUT — a method HTTP treats as unsafe and non-idempotent even though these calls never mutate data. With no safe, idempotent method that permits a body, read-with-body had to piggyback on PUT, mislabeling read traffic to proxies, caches, and retry logic. [sc-105627]
debdutgoswami
force-pushed
the
move-from-PUT-to-QUERY
branch
from
b099221 to
3d7b07a
Compare
sharoonthomas
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-oriented RPC calls (search, read, search_read, search_count) need a request body to carry filters and fields, so they were sent as PUT — a method HTTP treats as unsafe and non-idempotent even though these calls never mutate data. With no safe, idempotent method that permits a body, read-with-body had to piggyback on PUT, mislabeling read traffic to proxies, caches, and retry logic.
[sc-105627]