fix: make SHA and Ref values links to tree in external plugin intake comments#2100
Merged
aaronpowell merged 7 commits intoJun 23, 2026
Merged
Conversation
…comments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the external plugin intake comment by rendering the submitted Ref and SHA as clickable GitHub tree links so reviewers can jump directly to the exact source snapshot.
Changes:
- Update the merged intake + quality gates comment to linkify Ref/SHA.
- Update the intake-only comment to linkify Ref/SHA.
Show a summary per file
| File | Description |
|---|---|
| eng/external-plugin-intake.mjs | Updates intake comment rendering to turn Ref/SHA values into GitHub tree links. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| `- **Repository:** ${baseResult.plugin?.repository ?? "unknown"}`, | ||
| baseResult.plugin?.source?.ref ? `- **Ref:** ${baseResult.plugin.source.ref}` : undefined, | ||
| baseResult.plugin?.source?.sha ? `- **SHA:** ${baseResult.plugin.source.sha}` : undefined, | ||
| baseResult.plugin?.source?.ref ? `- **Ref:** [\`${baseResult.plugin.source.ref}\`](https://github.com/${encodeRepoPath(baseResult.plugin.source.repo)}/tree/${encodeURIComponent(baseResult.plugin.source.ref).replaceAll("%2F", "/")})` : undefined, |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the external plugin intake comment (e.g. issue #2089), the SHA and Ref fields were rendered as plain text. This makes it tedious to navigate to the actual plugin source at that point in time.
Both fields now render as clickable markdown links pointing to
https://github.com/{repo}/tree/{sha_or_ref}, so reviewers can jump directly to the plugin's tree at the pinned ref or commit.Updated both comment-generation paths in
eng/external-plugin-intake.mjs:applyQualityGateResult(quality gates + intake combined comment)generateIntakeComment(intake-only comment)