Skip to content

Exclude _test.sh artifacts from sync-actions mirroring#184

Open
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/update-sync-script-ignore-test-file
Open

Exclude _test.sh artifacts from sync-actions mirroring#184
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/update-sync-script-ignore-test-file

Conversation

Copilot AI commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

The sync workflow currently filters out JS test artifacts but still copies shell test scripts, allowing _test.sh files to leak into this repo during action sync. This change aligns shell test handling with existing JS test-file behavior.

  • Scope

    • Updates .github/workflows/sync-actions.yml in the action-folder sync step only.
  • Sync filtering

    • Extends rsync exclusions to skip shell test files: --exclude='*_test.sh'.
  • Post-sync cleanup parity

    • Adds explicit deletion of lingering *_test.sh files in destination action directories, matching the existing .test.cjs cleanup pattern.
rsync --archive --verbose --delete \
  --exclude='README*' \
  --exclude='*.test.cjs' \
  --exclude='*_test.sh' \
  "gh-aw/actions/$name/" "gh-aw-actions/$name/"

find "gh-aw-actions/$name" -type f -name '*_test.sh' -delete 2>/dev/null || true

Copilot AI changed the title chore: ignore and remove _test.sh files during sync Exclude _test.sh artifacts from sync-actions mirroring Jul 9, 2026
Copilot AI requested a review from pelikhan July 9, 2026 03:54
@pelikhan pelikhan marked this pull request as ready for review July 9, 2026 05:00
Copilot AI review requested due to automatic review settings July 9, 2026 05:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the sync-actions workflow’s action-folder mirroring so shell test artifacts don’t get copied into gh-aw-actions, bringing shell test handling in line with the existing JavaScript test-file exclusions.

Changes:

  • Extends the rsync exclusions to skip *_test.sh files during the action-folder sync.
  • Adds a post-sync cleanup find ... -delete to remove any lingering *_test.sh files in destination action directories (since excluded files won’t be removed by rsync --delete).
Show a summary per file
File Description
.github/workflows/sync-actions.yml Adds rsync exclude + post-sync deletion for *_test.sh to prevent shell test scripts from leaking into mirrored action folders.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants