refactor: extract X-Glean header names into constants#155
Merged
Conversation
Follow-up to #153. The X-Glean-Include-Experimental / X-Glean-Exclude-Deprecated-After header names and their env var names were duplicated across the hook and tests, so a rename had to touch many places. Define them once as module-level constants in x_glean.py and reference them everywhere.
chris-freeman-glean
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #153 addressing @steve-calvert-glean's review comment (review):
The
X-Glean-Include-Experimental/X-Glean-Exclude-Deprecated-Afterheader names (and their env var names) were duplicated in the hook and repeated 20+ times in tests, so the rename in #153 had to touch many places. This defines them once as module-level constants inx_glean.pyand references them from both the hook and the tests, so a future rename only changes one line.No behavior change; all 15 hook tests pass.