ci: add least-privilege read-only token permissions (22 workflows)#455
Open
Alb3e3 wants to merge 1 commit into
Open
ci: add least-privilege read-only token permissions (22 workflows)#455Alb3e3 wants to merge 1 commit into
Alb3e3 wants to merge 1 commit into
Conversation
Add a top-level `permissions: { contents: read }` block to the 22
GitHub Actions workflows that lacked one, so the automatic GITHUB_TOKEN
is granted only read access to repository contents by default.
Scoped to permissions only: the action-SHA pins from the earlier
revision are dropped to respect this repo's Dependabot-managed version
tags (e.g. the recent actions/checkout v6->v7 bump) and avoid churn.
No workflow behaviour changes.
Alb3e3
force-pushed
the
harden-ci-permissions-sha-pins
branch
from
1c79c9e to
4adaa72
Compare
Author
|
I've rebased this onto The previous revision also pinned action versions to commit SHAs, which conflicted with this repo's Dependabot-managed version tags (the recent No behaviour changes; the conflict is resolved and |
Alb3e3
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI workflows are missing top-level `permissions` declarations and reference actions by mutable tags/branch names — both are supply-chain risk vectors.
Changes:
Mutable action references (`@v4`, `@master`, etc.) allow a compromised upstream to inject arbitrary code into your CI. Pinning to a commit SHA ensures only the audited revision runs regardless of upstream changes.