feat(echo): add Echo:npm ecosystem with +echo.N ordering#5589
Open
LaizaAngrest wants to merge 3 commits into
Open
feat(echo): add Echo:npm ecosystem with +echo.N ordering#5589LaizaAngrest wants to merge 3 commits into
LaizaAngrest wants to merge 3 commits into
Conversation
npm/SemVer excludes build metadata from precedence, so delegate Echo:npm to a SemVer sort key composed with the +echo.N build number.
another-rex
previously approved these changes
Jul 8, 2026
Contributor
There was a problem hiding this comment.
There's a formatting issue, but other than that LGTM!
--- osv/ecosystems/_ecosystems_test.py
+++ osv/ecosystems/_ecosystems_test.py
@@ -121,8 +121,7 @@
self.assertLess(
echo_npm.sort_key('2.14.2+echo.1'), echo_npm.sort_key('2.14.2+echo.2'))
self.assertLess(
- echo_npm.sort_key('2.14.2+echo.2'),
- echo_npm.sort_key('2.14.2+echo.10'))
+ echo_npm.sort_key('2.14.2+echo.2'), echo_npm.sort_key('2.14.2+echo.10'))
self.assertLess(
echo_npm.sort_key('2.14.2+echo.1'), echo_npm.sort_key('2.14.3'))
Contributor
|
/gcbrun |
Contributor
Author
|
@another-rex Fixed the formatting — thanks for the review! |
Contributor
|
/gcbrun |
another-rex
approved these changes
Jul 9, 2026
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm/SemVer excludes build metadata from precedence, so delegate Echo:npm to a SemVer sort key composed with the +echo.N build number.