perf: improve speed of combine-to-osv cron#5609
Open
jess-lowe wants to merge 8 commits into
Open
Conversation
another-rex
reviewed
Jul 9, 2026
| } | ||
| osvRecords[cveID] = baseOSV | ||
| // Collect all unique CVE IDs | ||
| allIDs := make(map[models.CVEID]bool) |
Contributor
There was a problem hiding this comment.
nit: map[models.CVEID]struct{}
|
|
||
| // Interpose Collector to gather valid IDs | ||
| var validIDs []string | ||
| var idWg sync.WaitGroup |
Contributor
There was a problem hiding this comment.
Use some longer variable names, it's unclear what this waitgroup is for.
| if len(v.GetAffected()) > 0 { | ||
| validIDs = append(validIDs, v.GetId()) | ||
| } | ||
| validVulnChan <- v |
Contributor
There was a problem hiding this comment.
It seems like validVulnChan is named wrong? It's just all vulns right? Maybe you want to call it uploadVulnsChan?
another-rex
reviewed
Jul 9, 2026
Comment on lines
+19
to
+20
| INPUT_BUCKET="${INPUT_GCS_BUCKET:=osv-test-cve-osv-conversion}" | ||
| OUTPUT_BUCKET="${OUTPUT_GCS_BUCKET:=osv-test-cve-osv-conversion}" |
Contributor
There was a problem hiding this comment.
Is this change intentional? I think this will break prod.
Contributor
There was a problem hiding this comment.
The kubernetes files are not correctly setting the bucket env variables I believe. Please double check.
another-rex
reviewed
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloading via gcloud was taking 25+ minutes, this does the download in go, and in parallel with a bunch of workers