Skip to content

feat(storage): Migrate async client to unified checksum options#16261

Open
v-pratap wants to merge 8 commits into
googleapis:mainfrom
v-pratap:unified-checksum-options-pr2
Open

feat(storage): Migrate async client to unified checksum options#16261
v-pratap wants to merge 8 commits into
googleapis:mainfrom
v-pratap:unified-checksum-options-pr2

Conversation

@v-pratap

Copy link
Copy Markdown
Contributor

Migrates the Async client (connection_impl.cc, object_descriptor_impl.cc) to use the newly introduced unified checksum options. Also includes the necessary fallback logic to support users who are still using the deprecated options.

Note: This PR is stacked on top of #16260 and includes its commit. It should be merged after #16260.

@v-pratap v-pratap requested review from a team as code owners July 15, 2026 09:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces UploadChecksumValidationOption and DownloadChecksumValidationOption to configure checksum algorithms for uploads and downloads, deprecating the older EnableCrc32cValidationOption and EnableMD5ValidationOption. It updates the internal connection and reader implementations to respect these new options with fallback support, adds corresponding unit and integration tests, and provides a code sample. The reviewer feedback highlights that the fallback logic for download checksum validation is duplicated three times across non-test files and suggests refactoring it into a shared helper function in accordance with the repository style guide.

Comment thread google/cloud/storage/internal/async/connection_impl.cc Outdated
Comment thread google/cloud/storage/internal/async/object_descriptor_impl.cc Outdated
Comment thread google/cloud/storage/internal/async/object_descriptor_impl.cc Outdated
@v-pratap v-pratap force-pushed the unified-checksum-options-pr2 branch 3 times, most recently from 9ed6fe1 to 2799489 Compare July 15, 2026 10:27
@v-pratap v-pratap force-pushed the unified-checksum-options-pr2 branch 2 times, most recently from 67305d6 to 8bd3544 Compare July 15, 2026 10:56
@v-pratap v-pratap added the do not review Indicates a PR is not ready for review label Jul 15, 2026
@v-pratap v-pratap force-pushed the unified-checksum-options-pr2 branch from 8bd3544 to 1268c7f Compare July 15, 2026 11:27
@v-pratap v-pratap changed the title Migrate async client to unified checksum options feat(storage): Migrate async client to unified checksum options Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (e493b2d) to head (dc5fbb5).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16261      +/-   ##
==========================================
- Coverage   92.27%   92.27%   -0.01%     
==========================================
  Files        2214     2215       +1     
  Lines      206505   206544      +39     
==========================================
+ Hits       190556   190586      +30     
- Misses      15949    15958       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 16, 2026
@v-pratap v-pratap removed the do not review Indicates a PR is not ready for review label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant