Skip to content

Surface unranked leaderboard submissions#70

Merged
msaroufim merged 1 commit into
mainfrom
badelsteinlelbach-cli
Jul 5, 2026
Merged

Surface unranked leaderboard submissions#70
msaroufim merged 1 commit into
mainfrom
badelsteinlelbach-cli

Conversation

@msaroufim

Copy link
Copy Markdown
Member

Summary

  • make completed leaderboard submissions without a qualifying public score plus secret validation fail in the submit polling flow
  • show not ranked in submission lists when a completed submission has no ranked runs
  • show server job status and job error in submission details
  • add unit coverage for secret failures, missing secret leaderboard validation, missing public scores, and non-leaderboard modes

Root Cause

The CLI exited successfully once the server marked a submission done unless the job status was explicitly failed. That made legacy or in-flight succeeded jobs with no qualifying leaderboard score look like successful submissions.

Impact

Leaderboard submissions that pass public validation but fail secret validation now surface a clear CLI error instead of printing successful JSON with an empty or unscored result.

Validation

  • cargo fmt --all -- --check
  • cargo test
  • cargo clippy --all-targets --all-features -- -D warnings

@msaroufim msaroufim marked this pull request as ready for review July 5, 2026 02:31
@msaroufim msaroufim merged commit 4c09e16 into main Jul 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant