Surface unranked leaderboard submissions#70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
not rankedin submission lists when a completed submission has no ranked runsRoot Cause
The CLI exited successfully once the server marked a submission
doneunless the job status was explicitly failed. That made legacy or in-flightsucceededjobs with no qualifying leaderboard score look like successful submissions.Impact
Leaderboard submissions that pass public validation but fail secret validation now surface a clear CLI error instead of printing successful JSON with an empty or unscored result.
Validation
cargo fmt --all -- --checkcargo testcargo clippy --all-targets --all-features -- -D warnings