Skip to content

Restore per-row results for polled submissions#74

Merged
msaroufim merged 1 commit into
mainfrom
fix/polled-submission-results
Jul 6, 2026
Merged

Restore per-row results for polled submissions#74
msaroufim merged 1 commit into
mainfrom
fix/polled-submission-results

Conversation

@msaroufim

Copy link
Copy Markdown
Member

Summary

  • parse optional persisted run results returned by KernelBot polling
  • render ordered per-row output for test and benchmark submissions
  • retain background polling for test, benchmark, and leaderboard durability; native profile remains on SSE
  • preserve queue updates, leaderboard geomean output, and secret-validation failure handling
  • fall back to the existing summary when talking to an older server

Root cause

The background submission migration made jobs resilient to client disconnects, but the polling response omitted the detailed result map used to render individual rows. Returning to SSE would restore rows while reintroducing cancellation on disconnect.

Backend dependency

Requires gpu-mode/kernelbot#511. That API change is additive and exposes results only for non-secret test/benchmark runs. This client also filters secret runs defensively.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo test (45 passed)
  • mock HTTP regression covering background test/benchmark/leaderboard routes, row rendering, and profile SSE

Kernelboard is unaffected: it uses the unchanged submission POST contract and does not consume the owner-only submission-details endpoint.

@msaroufim msaroufim marked this pull request as ready for review July 6, 2026 21:59
@msaroufim msaroufim merged commit 16a858f into main Jul 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant