Restore per-row results for polled submissions#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testandbenchmarksubmissionsRoot cause
The background submission migration made jobs resilient to client disconnects, but the polling response omitted the detailed result map used to render individual rows. Returning to SSE would restore rows while reintroducing cancellation on disconnect.
Backend dependency
Requires gpu-mode/kernelbot#511. That API change is additive and exposes results only for non-secret test/benchmark runs. This client also filters secret runs defensively.
Validation
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test(45 passed)Kernelboard is unaffected: it uses the unchanged submission POST contract and does not consume the owner-only submission-details endpoint.