Make CertVerifier buffer size a const generic on HttpClient#1
Open
abhay wants to merge 2 commits into
Open
Conversation
Adds `const CERT_SIZE: usize = 4096` to `TlsConfig`, `Provider`, and `HttpClient` (all behind `#[cfg(feature = "embedded-tls")]`). This lets consumers specify a larger certificate chain buffer for servers with long chains (e.g. Telegram's 4-cert chain needs ~6144 bytes). Default of 4096 preserves backward compatibility — existing code compiles unchanged. Also points embedded-tls dependency at hackshare/embedded-tls fork (hw-rsa branch) for hardware RSA offload support. Removes stale esp-mbedtls git dep (URL no longer resolves) and suppresses cfg warnings for its dormant code paths.
abhay
force-pushed
the
feat/cert-size-generic
branch
from
e21f665 to
7cce9ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
const CERT_SIZE: usize = 4096toTlsConfig,Provider, andHttpClient(all behind#[cfg(feature = "embedded-tls")]). This lets consumers specify a larger certificate chain buffer for servers with long chains (e.g. Telegram's 4-cert chain needs ~6144 bytes).Default of 4096 preserves backward compatibility — existing code compiles unchanged.
Also points embedded-tls dependency at hackshare/embedded-tls fork (hw-rsa branch) for hardware RSA offload support. Removes stale esp-mbedtls git dep (URL no longer resolves) and suppresses cfg warnings for its dormant code paths.