fix: type JSON metadata filter attributes#2537
Merged
kodiakhq[bot] merged 3 commits intoJun 29, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: e1d5250 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mfroembgen is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThis PR fixes metadata value sampling for JSON-backed attributes. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix: quote typed-looking JSON metadata k..." | Re-trigger Greptile |
fleon
approved these changes
Jun 29, 2026
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GROUP BY,groupUniqArray, and fallback value lookups.getKeyValues,getValuesDistribution, andgetMapValues.Validation:
mise exec node@22.16.0 -- corepack yarn workspace @hyperdx/common-utils jest --runInBand src/__tests__/metadata.test.tsmise exec node@22.16.0 -- corepack yarn workspace @hyperdx/common-utils ci:lintmise exec node@22.16.0 -- corepack yarn workspace @hyperdx/common-utils ci:unitDuplicate/overlap check: I did not find another PR fixing #2482. #2423 touches faceted filter values but is a separate draft feature and does not address JSON typed subcolumn rendering.
Screenshots or video
N/A - non-UI change
How to test on Vercel preview
N/A - non-UI change
References