feat(method): add QUERY method#798
Merged
Merged
Conversation
Member
Author
|
Though, I wouldn't be opposed to waiting ever so slightly with merging this, to allow the IETF to finish, and include it in v1.5 instead of v1.4. |
seanmonstar
force-pushed
the
push-lxlvmqrmmnsp
branch
from
8c7f820 to
cec37ba
Compare
Member
Author
|
It has just been fully accepted today: https://www.rfc-editor.org/info/rfc10008/ So let's merge 😎 |
tgross35
reviewed
Jun 17, 2026
Comment on lines
+411
to
+413
| // This is purposefully excluded because of potential conflict with the | ||
| // URI query. | ||
| // pub fn query() -> Builder |
There was a problem hiding this comment.
Bit late here, but could this be added as perhaps http_query if there is concern about a conflict?
For what it's worth, I don't find the conflict too worrisome: if there were a method to get the URI query, I'd expect that to be called uri_query, and this being a zero-param associated function (rather than a method to get the URI query, or a 1-param function to build a GET with one) is a pretty big clue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IESG has just confirmed promoting QUERY to Proposed Standard: https://lists.w3.org/Archives/Public/ietf-http-wg/2025OctDec/0208.html