Perf & mem optimizations#179
Open
OBrezhniev wants to merge 12 commits into
Open
Conversation
…fers to worker threads instead of arrays (make it compatible with SharedArrayBuffer)
Fix nChunks calculation - drastically improve memory usage. Increase min chunk size to 1<<15 (32k) - speed improvement on smaller circuits. Serial chunk processing - better mem usage. Linter fixes
- remove chunking of chunks (removes unneeded copying of the same data to different worker jobs), - make nChunks multiple of tm.concurrency for optimal load balancing - switch back to promises from awaits (allows parallel execution of chunks) - rollback min chunk size - transfer buffer ownership to worker threads (removes memory copying for large arrays!!!)
…ination Replace parallel index arrays (workers[], initialized[], working[], etc.) with a WorkerSlot class that owns all per-worker state. Message handlers close over the slot reference, so stale messages from replaced workers are detected by a simple identity check (pool[i] !== slot) rather than generation counters. 2-phase termination protocol: - Worker fires want_to_terminate when idle timer expires (200ms, down from 1s) - Main thread nulls pool[i] immediately, sends TERMINATE ack, calls processWorks so a replacement worker can start filling the slot right away - Worker's subsequent terminated message arrives stale and only removes event listeners to break the slot→worker→closure reference cycle for prompt GC - Stale task results (want_to_terminate race with in-flight dispatch) are still resolved correctly so callers never hang Additional fixes: - scheduleTermination() moved inside init().then() so the 200ms idle timer never fires during async WASM compilation - removeEventListener called on both stale and non-stale terminated paths so WASM memory held by old slots is released immediately, not GC-deferred - processWorks start-new-workers loop no longer calls startWorker() on slots that are already occupied (working or initializing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.