Skip to content

CROSSLINK-296 supplier requester name facets#656

Open
adamdickmeiss wants to merge 19 commits into
mainfrom
CROSSLINK-296-supplier-requester-name-facets
Open

CROSSLINK-296 supplier requester name facets#656
adamdickmeiss wants to merge 19 commits into
mainfrom
CROSSLINK-296-supplier-requester-name-facets

Conversation

@adamdickmeiss

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 8, 2026 18:15
@adamdickmeiss adamdickmeiss marked this pull request as draft July 8, 2026 18:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds requester/supplier peer names as first-class searchable/facetable fields on the patron-requests API, by extending the patron_request_search_view and wiring the new fields through CQL parsing, facet generation, API mapping, and OpenAPI.

Changes:

  • Extend patron_request_search_view with requester_name / supplier_name (resolved via symbol -> peer) and add a DB migration for the view change.
  • Add CQL support + facets allowlist support for requester_name / supplier_name, and expose these fields on the API response model.
  • Add an integration-style API test covering exact match, wildcard match, case-insensitive match, and facet output for the new fields.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
broker/test/patron_request/api/api-handler_test.go Adds API-level test coverage for requester/supplier name CQL filters and facets.
broker/sqlc/sqlc.yaml Updates sqlc config to include ill_schema.sql for the PR query package and adds type overrides for new view columns.
broker/sqlc/pr_schema.sql Updates the SQL definition of patron_request_search_view used for sqlc generation to include peer names.
broker/sqlc/ill_schema.sql Adds a peer-name index (and comment) in the schema file used by sqlc parsing.
broker/patron_request/db/prrepo.go Allows requester_name / supplier_name as valid facet fields.
broker/patron_request/db/prcql.go Adds CQL field definitions for requester_name / supplier_name and updates scan order for the view.
broker/patron_request/api/api-handler.go Maps new DB view fields onto API response fields.
broker/oapi/open-api.yaml Documents new CQL fields/facets and adds requesterName / supplierName properties to the schema.
broker/migrations/047_add_peer_name_to_search_view.up.sql Introduces migration for adding peer-name columns to the search view (plus new index).
broker/migrations/047_add_peer_name_to_search_view.down.sql Reverts the new index and restores the previous view definition.

Comment thread broker/migrations/048_add_peer_name_to_search_view.up.sql
Comment thread broker/migrations/047_add_peer_name_to_search_view.up.sql Outdated
Comment thread broker/sqlc/ill_schema.sql Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 10:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Comment thread broker/sqlc/ill_schema.sql Outdated
Comment thread broker/migrations/047_add_peer_name_to_search_view.down.sql Outdated
Comment thread broker/migrations/047_add_peer_name_to_search_view.up.sql Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 11:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread broker/test/patron_request/api/api-handler_test.go Outdated
Copilot AI review requested due to automatic review settings July 9, 2026 12:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 10, 2026 11:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread broker/migrations/047_add_peer_name_to_search_view.down.sql Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 10, 2026 11:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 10, 2026 12:26
@adamdickmeiss adamdickmeiss marked this pull request as ready for review July 10, 2026 12:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 10, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread broker/test/patron_request/api/api-handler_test.go Outdated
Copilot AI review requested due to automatic review settings July 10, 2026 13:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Comment thread broker/test/patron_request/api/api-handler_test.go Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 10, 2026 14:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants