CROSSLINK-296 supplier requester name facets#656
Open
adamdickmeiss wants to merge 19 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds requester/supplier peer names as first-class searchable/facetable fields on the patron-requests API, by extending the patron_request_search_view and wiring the new fields through CQL parsing, facet generation, API mapping, and OpenAPI.
Changes:
- Extend
patron_request_search_viewwithrequester_name/supplier_name(resolved viasymbol -> peer) and add a DB migration for the view change. - Add CQL support + facets allowlist support for
requester_name/supplier_name, and expose these fields on the API response model. - Add an integration-style API test covering exact match, wildcard match, case-insensitive match, and facet output for the new fields.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| broker/test/patron_request/api/api-handler_test.go | Adds API-level test coverage for requester/supplier name CQL filters and facets. |
| broker/sqlc/sqlc.yaml | Updates sqlc config to include ill_schema.sql for the PR query package and adds type overrides for new view columns. |
| broker/sqlc/pr_schema.sql | Updates the SQL definition of patron_request_search_view used for sqlc generation to include peer names. |
| broker/sqlc/ill_schema.sql | Adds a peer-name index (and comment) in the schema file used by sqlc parsing. |
| broker/patron_request/db/prrepo.go | Allows requester_name / supplier_name as valid facet fields. |
| broker/patron_request/db/prcql.go | Adds CQL field definitions for requester_name / supplier_name and updates scan order for the view. |
| broker/patron_request/api/api-handler.go | Maps new DB view fields onto API response fields. |
| broker/oapi/open-api.yaml | Documents new CQL fields/facets and adds requesterName / supplierName properties to the schema. |
| broker/migrations/047_add_peer_name_to_search_view.up.sql | Introduces migration for adding peer-name columns to the search view (plus new index). |
| broker/migrations/047_add_peer_name_to_search_view.down.sql | Reverts the new index and restores the previous view definition. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…r-requester-name-facets
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://index-data.atlassian.net/browse/CROSSLINK-296