Skip to content

feat(styles,react): use button and button card as links#16

Merged
Gnuk merged 1 commit into
mainfrom
remove-underline-on-a-button
Jul 7, 2026
Merged

feat(styles,react): use button and button card as links#16
Gnuk merged 1 commit into
mainfrom
remove-underline-on-a-button

Conversation

@Gnuk

@Gnuk Gnuk commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

What

Allow button and button-card to be used as links (<a href>) without underline, in both the Pattern Library and the React components.

Pattern Library (@ippon-ui/styles 0.0.8)

  • text-decoration: none on .ippon-button and .ippon-button-card
  • ippon-button and ippon-button-card Pug mixins accept an href option and render an <a> instead of a <button> (same convention as the tab atom)
  • Link examples added to both component docs, render heights adjusted so nothing is cut off

React (@ippon-ui/react 0.0.7)

  • New IpponLinkButton and IpponLinkButtonCard components: link (<a href>) counterparts of IpponButton and IpponButtonCard, sharing their look but exposing only link-relevant props (href required; no disabled, loading or popover behavior, which only make sense on real buttons)
  • Shared button types and icon rendering extracted to Button.tsx, consumed by both IpponButton and IpponLinkButton
  • Dedicated Storybook stories (Atom/LinkButton, Organism/LinkButtonCard), README example, dedicated specs (256 tests passing)
  • Peer dependency raised to @ippon-ui/styles ~0.0.8 (link rendering relies on the new underline reset)

Notes

  • CHANGELOG entry added for both packages
  • The [unplugin:dts] api-extractor build warning is pre-existing and unrelated

🤖 Generated with Claude Code

@Gnuk Gnuk force-pushed the remove-underline-on-a-button branch from 41b2690 to 345d6ec Compare July 7, 2026 17:59
Comment thread styles/src/atom/button/button.md Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Gnuk Gnuk force-pushed the remove-underline-on-a-button branch from 345d6ec to 8034756 Compare July 7, 2026 18:03
@Gnuk Gnuk merged commit a65c8f0 into main Jul 7, 2026
3 checks passed
@Gnuk Gnuk deleted the remove-underline-on-a-button branch July 7, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant