feat(styles,react): use button and button card as links#16
Merged
Conversation
41b2690 to
345d6ec
Compare
Gnuk
commented
Jul 7, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
345d6ec to
8034756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow
buttonandbutton-cardto be used as links (<a href>) without underline, in both the Pattern Library and the React components.Pattern Library (
@ippon-ui/styles0.0.8)text-decoration: noneon.ippon-buttonand.ippon-button-cardippon-buttonandippon-button-cardPug mixins accept anhrefoption and render an<a>instead of a<button>(same convention as thetabatom)React (
@ippon-ui/react0.0.7)IpponLinkButtonandIpponLinkButtonCardcomponents: link (<a href>) counterparts ofIpponButtonandIpponButtonCard, sharing their look but exposing only link-relevant props (hrefrequired; nodisabled, loading or popover behavior, which only make sense on real buttons)Button.tsx, consumed by bothIpponButtonandIpponLinkButtonAtom/LinkButton,Organism/LinkButtonCard), README example, dedicated specs (256 tests passing)@ippon-ui/styles ~0.0.8(link rendering relies on the new underline reset)Notes
[unplugin:dts] api-extractorbuild warning is pre-existing and unrelated🤖 Generated with Claude Code