Run Rector from the Claude Code setup; drop redundant root user from the release workflow#57
Merged
Merged
Conversation
Mirror event-database-imports#107's Claude integration for Rector (the CI gate and Taskfile targets already landed in the Rector PR): - PostToolUse hook runs `rector process` on the edited src/tests PHP file before php-cs-fixer, so single-file edits are modernized then formatted. - pr-readiness agent gains a Rector (dry-run) check mirroring the CI gate. - CLAUDE.md notes Rector in the PostToolUse list.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #57 +/- ##
==========================================
Coverage 72.89% 72.89%
Complexity 232 232
==========================================
Files 29 29
Lines 653 653
==========================================
Hits 476 476
Misses 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Mirror devops_itkdev-docker#116: the phpfpm service runs as
${COMPOSE_USER:-deploy}, so the release job's `--user=root` (and the
`COMPOSER_ALLOW_SUPERUSER` that paired with it) are redundant. Set
`COMPOSE_USER: runner` at the workflow level and drop both, keeping
APP_ENV inline via `-e APP_ENV=prod`.
turegjorup
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small tooling changes.
Rector in the Claude Code setup (mirrors event-database-imports#107)
The Rector CI gate + Taskfile targets already landed here in the Rector PR; this adds the Claude-integration parts:
.claude/settings.json—PostToolUsehook runsrector processon editedsrc//tests/PHP before php-cs-fixer..claude/agents/pr-readiness.md— adds a Rector (dry-run) step after PHPStan.PostToolUsedescription.Drop redundant root user from the release workflow (mirrors devops_itkdev-docker#116)
phpfpmruns as${COMPOSE_USER:-deploy}, sobuild_release.yml's--user=root— and theCOMPOSER_ALLOW_SUPERUSERthat paired with it — were redundant. SetCOMPOSE_USER: runnerat the workflow level, drop both, keepAPP_ENVinline via-e APP_ENV=prod.