fix(pe/cui): allow a letter as the optional check digit#162
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Peruvian CUI validation logic to correctly handle check digits that include letters. By restricting the digit format check to the first 8 characters, the validator now supports alphanumeric check digits, preventing valid IDs from being incorrectly rejected. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a test case for validating '10812543-H' and updates the validation logic in src/pe/cui.ts to check only the first 8 characters for digits. The feedback recommends replacing the deprecated String.prototype.substr() method with String.prototype.substring().
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| return { isValid: false, error: new exceptions.InvalidLength() }; | ||
| } | ||
| if (!strings.isdigits(value)) { | ||
| if (!strings.isdigits(value.substr(0, 8))) { |
There was a problem hiding this comment.
The String.prototype.substr() method is deprecated and its use is discouraged in modern JavaScript/TypeScript. It is recommended to use standard methods like String.prototype.substring() or String.prototype.slice() instead.
| if (!strings.isdigits(value.substr(0, 8))) { | |
| if (!strings.isdigits(value.substring(0, 8))) { |
1 participant
A Peruvian CUI's optional check character can be a letter (
K…A) as well as a digit; the two possible check characters are already computed, but the format guard appliesisdigitsto the entire value, so a valid number such as10812543-His rejected withInvalidFormatbefore the checksum is evaluated.Restrict the digit check to the first 8 characters, matching python-stdnum's
isdigits(number[:8]), so the existing check-digit logic can evaluate the letter (validate('10812543-H')→'10812543H').