Skip to content

Fix Scorecard SARIF publication#19

Merged
krotname merged 1 commit into
mainfrom
feature/scorecard-action-sarif-20260621
Jun 21, 2026
Merged

Fix Scorecard SARIF publication#19
krotname merged 1 commit into
mainfrom
feature/scorecard-action-sarif-20260621

Conversation

@krotname

Copy link
Copy Markdown
Owner

Summary

  • use pinned ossf/scorecard-action for SARIF output
  • grant OIDC permission required by publish_results
  • upload Scorecard SARIF to Code Scanning

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e29cd47163

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

--output="scorecard-results.sarif" \
--show-details
- name: Run Scorecard
uses: ossf/scorecard-action@4eaacf0543bb3f2c246792bd56e8cdeffafb205a # v2.4.3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve dispatch runs on selected branches

Because this workflow still has workflow_dispatch, a maintainer can manually run it against a feature or release branch, but ossf/scorecard-action v2.4.3 rejects any non-PR event whose GITHUB_REF is not the repository default branch with only default branch is supported. The previous CLI path analyzed ${GITHUB_SHA} and produced/uploaded SARIF for those manual branch runs, so this replacement makes that advertised trigger fail before the SARIF and artifact upload steps; either restrict dispatch to the default branch or keep a non-default-branch path that does not use the action's default-branch validation.

Useful? React with 👍 / 👎.

@krotname krotname merged commit d8e6076 into main Jun 21, 2026
10 of 11 checks passed
@krotname krotname deleted the feature/scorecard-action-sarif-20260621 branch June 21, 2026 19:45
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant