fix: update install-hooks target to use pre-commit install#731
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
erangeles
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
N/A
Describe the solution you've provided
The
install-hooksMakefile target was broken — it referencedgit/hooks/*which was removed in a previous commit. The repo now uses thepre-commitframework (.pre-commit-config.yaml), so the target is updated to runpre-commit install.How to test it
Run
make install-hooks— it should succeed and install the pre-commit hook.Describe alternatives you've considered
Could recreate the old
git/hooks/directory, but the repo has already migrated to thepre-commitframework so this aligns with that.Additional context
None.
Link to Devin session: https://app.devin.ai/sessions/a88b0e232de74902a54218c38843a6b2
Requested by: @ffantl-ld
Note
Low Risk
Makefile-only change for local dev hook setup; no runtime or CI behavior change beyond fixing a broken target.
Overview
Fixes broken
make install-hooksby replacing the removedgit/hooks/*copy step withpre-commit install, matching the repo’s.pre-commit-config.yamlsetup.Contributors running
make install-hooks(documented in CONTRIBUTING.md and AGENTS.md) get working git hooks again instead of a failing Makefile target.Reviewed by Cursor Bugbot for commit 04154c1. Bugbot is set up for automated code reviews on this repo. Configure here.