Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lde | af1a635 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 04:33 AM |
Collaborator
Author
|
To integrate lua-sys, need windows symbols to be exported: #147 |
Collaborator
Author
|
Blocked by some odd regression? at some point. Nondeterministic segfaults when running the compile step. Related to previous issue about linker / libc implementation freeing luajit ffi objects. But happens on master branch as well so unrelated to changes here. |
Also makes it so postexec doesnt need to be supported.
Going to instead download a separate luajit lib instead of trying to get windows to expose symbols. Oh well.
Not sure how it even worked without this
This should allow build.lua scripts that use processes like ninja to find a compiler like gcc despite lde not installing them globally.
Also simplifies code significantly by using auto coercion and table setting
bycruz
force-pushed
the
no-ffix
branch
7 times, most recently
from
14cf565 to
f88d86d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason why it was integrated was out of the need for lde to run itself without clashing with its own ffi symbols and not being able to update.
However it has become problematic for several reasons
Since this doesn't really seem necessary to users I'll ditch it and figure out an alternative. For now, my option is likely going to be using https://github.com/lde-org/lua-sys to create an isolated lua state to
lde runwith instead of pseudo-sandboxing with setfenv. It will also increase security to introduce this.