Upgrade 2026_07_15 SRV3 & CMV2#644
Draft
Amuhar wants to merge 36 commits into
Draft
Conversation
upgrade vote test
iamnp
reviewed
Jul 9, 2026
|
|
||
|
|
||
| # ---- event validators -------------------------------------------------------- | ||
| def validate_proxy_upgrade_event( |
Contributor
There was a problem hiding this comment.
use generic event validators from utils folder or move generic ones to it
… before upgrade migration
…44-base test: add staking modules vote regressions
iamnp
reviewed
Jul 10, 2026
Comment on lines
+121
to
+129
| DG_PROPOSAL_METADATA = "Activate Staking Router v3 + Curated Module v2 + Community Staking Module v3" | ||
| DG_SUBMISSION_DESCRIPTION = "1. Submit a Dual Governance proposal to activate Staking Router v3 + Curated Module v2 + Community Staking Module v3" | ||
| IPFS_DESCRIPTION = """ | ||
| 1. **Activate Staking Router v3**, including protocol contract upgrades and Dual Governance execution setup. Items 1.1-1.19. | ||
| 2. **Upgrade Community Staking Module to v3**, including CSM contract upgrades, role updates and identified DVT cluster setup. Items 1.20-1.56. | ||
| 3. **Add and configure Curated Module v2**. Items 1.57-1.68. | ||
| 4. **Finalize the protocol upgrade**. Item 1.69. | ||
| 5. **Update Easy Track factories for CSM v3 and Curated Module v2 operations**. Items 2-12. | ||
| """ |
iamnp
reviewed
Jul 10, 2026
Comment on lines
+132
to
+137
| def is_placeholder_vote_script_address(value: str) -> bool: | ||
| normalized = value.strip().lower() | ||
| return normalized in ( | ||
| "", | ||
| "0x0000000000000000000000000000000000000000", | ||
| ) or normalized.startswith("todo") |
vgorkavenko
reviewed
Jul 10, 2026
| event=vote_events[5], | ||
| p=EVMScriptFactoryAdded( | ||
| factory_addr=ctx["set_merkle_gate_tree_for_csm_factory"], | ||
| permissions=csm_tree_gate_permissions, |
Contributor
There was a problem hiding this comment.
Not sure it is worth to have variable here. For # 4. Add UpdateStakingModuleShareLimits ET factory you don't have it
| event=vote_events[8], | ||
| p=EVMScriptFactoryAdded( | ||
| factory_addr=ctx["set_merkle_gate_tree_for_cm_factory"], | ||
| permissions=curated_tree_gate_permissions, |
Contributor
There was a problem hiding this comment.
The same as above. It reduces readability
| emitted_by=ctx["triggerable_withdrawals_gateway"], | ||
| ) | ||
|
|
||
| # 1.17. Set TWG exit request limits |
Contributor
There was a problem hiding this comment.
No revoke after setting?
Comment on lines
+1252
to
+1253
| ctx["cs_fee_oracle_consensus_version"], | ||
| initial_cs_fee_oracle_consensus_version, |
Contributor
There was a problem hiding this comment.
Should be taken from constants? As for AO and EB oracles checks above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains work on tests for the upcoming SRV3 & CMV2 release.
acceptance tests passed