feat: allow setting custom preimage in spontaneous-send#233
Open
f3r10 wants to merge 1 commit into
Open
Conversation
|
I've assigned @benthecarman as a reviewer! |
benthecarman
requested changes
Jun 15, 2026
| bolt11_invoice_description, Bolt11InvoiceDescription, | ||
| }; | ||
|
|
||
| use ldk_server_grpc::types::payment_kind; |
Collaborator
There was a problem hiding this comment.
nit: can we have a new line between the imports and const
| help = "Custom TLV record to attach, format: <type_num>:<hex_value>. Repeatable. type_num must be >= 65536." | ||
| )] | ||
| custom_tlvs: Vec<(u64, Vec<u8>)>, | ||
| #[arg(long)] |
Collaborator
There was a problem hiding this comment.
please add help text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #226
Summary
preimagefield toSpontaneousSendRequest, allowing callers to supply a custom 32-byte hex preimage instead of having the node generate one randomlysend_with_preimageorsend_with_preimage_and_custom_tlvs) based on whether preimage and/or custom TLVs are present--preimage) and MCP schemaSHA256 of the provided preimage