Skip to content

Few LSPS fixes#4700

Merged
tnull merged 3 commits into
lightningdevkit:mainfrom
tnull:2026-06-liquidity-persist-review-fixes
Jun 17, 2026
Merged

Few LSPS fixes#4700
tnull merged 3 commits into
lightningdevkit:mainfrom
tnull:2026-06-liquidity-persist-review-fixes

Conversation

@tnull

@tnull tnull commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

.. just a few minor fixes/nits that claude review found on another PR (#4662).

@ldk-reviews-bot

ldk-reviews-bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

👋 I see @tankyleo was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnull tnull mentioned this pull request Jun 16, 2026
Closed
@ldk-claude-review-bot

ldk-claude-review-bot commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

The changes are correct: in both lsps2/service.rs:1863 and lsps5/service.rs:337, the else branch calls persist_peer_state which does persist data, so setting did_persist = true correctly reflects that persistence occurred (previously this was a bug where it returned a stale value). The doc typo fixes ("sevice" → "service") are also correct.

No issues found.

@ldk-reviews-bot ldk-reviews-bot requested a review from tankyleo June 16, 2026 09:57
@TheBlueMatt

TheBlueMatt commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Please word-wrap your commit messages.

@TheBlueMatt TheBlueMatt removed the request for review from tankyleo June 16, 2026 17:12
tnull added 3 commits June 17, 2026 09:15
@tnull
Document LiquidityManager persist result
12815f3 
Clarify the return value so callers know it reports whether the
forced peer-state write reached the store.

Co-Authored-By: HAL 9000
@tnull
Report LSPS2 fallback persistence
a1cda95 
When a prunable peer gains state before removal, persist() now reports
that the forced peer-state write reached the store.

Co-Authored-By: HAL 9000
@tnull
Report LSPS5 fallback persistence
d757191 
When a prunable client gains state before removal, persist() now reports
that the forced peer-state write reached the store.

Co-Authored-By: HAL 9000
@tnull tnull force-pushed the 2026-06-liquidity-persist-review-fixes branch from bbb6af6 to d757191 Compare June 17, 2026 07:17
@tnull

tnull commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Please word-wrap your commit messages.

Grrrr. Done.

@tnull tnull merged commit 6cd4ba6 into lightningdevkit:main Jun 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

Assignees

No one assigned

Labels

backport 0.2 backport 0.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tnull @ldk-reviews-bot @ldk-claude-review-bot @TheBlueMatt