poller: support different tree name and prefix#78
Open
matttbe wants to merge 1 commit into
Open
Conversation
The current code was assuming that the tree name and prefix were always the same, but that's not necessary the case. Instead, pass a list of Trees, so it is possible to access to both the name and prefix. Note: this modification requires an adaptation of the list module, e.g. for those not using the "netdev" modules. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Member
Author
Or maybe we don't need this, and force the tree name and prefix to be identical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code was assuming that the tree name and prefix were always the same, but that's not necessary the case.
Instead, pass a list of Trees, so it is possible to access to both the name and prefix.
Note: this modification requires an adaptation of the list module, e.g. for those not using the "netdev" modules.
==> Are there many users of this list module? I guess no, but if yes, I can also modify the code to only pass the prefixes to
series_tree_name_direct()(instead of the names like before this PR), and then find the tree name associated to such prefix.