MLE-28498 Undoing addition of xdmp-login to test app#1953
Open
rjrudin wants to merge 1 commit into
Open
Conversation
Depends on the server no longer requiring the xdmp-login privilege for using REST extensions or transforms.
There was a problem hiding this comment.
Pull request overview
Removes the previously-added xdmp-login privilege and related test-app security artifacts now that the MarkLogic server no longer requires xdmp-login for using REST extensions/transforms.
Changes:
- Removed the
java-test-xdmp-loginrole and eliminated its assignment from test-app users. - Removed
xdmp-loginfrom thetest-rest-writerrole privileges. - Updated functional tests to stop creating roles with the
xdmp-loginprivilege; removed an unused REST transform execution user config.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test-app/src/main/ml-config/security/users/writer-no-default-permissions.json | Removes java-test-xdmp-login from the user’s role list. |
| test-app/src/main/ml-config/security/users/rest-writer.json | Removes java-test-xdmp-login from the user’s role list. |
| test-app/src/main/ml-config/security/users/rest-transform-user.json | Removes obsolete REST transform execution user config. |
| test-app/src/main/ml-config/security/users/rest-evaluator.json | Removes java-test-xdmp-login from the user’s role list. |
| test-app/src/main/ml-config/security/users/rest-admin.json | Removes java-test-xdmp-login from the user’s role list. |
| test-app/src/main/ml-config/security/roles/test-rest-writer.json | Removes the explicit xdmp-login privilege from the role. |
| test-app/src/main/ml-config/security/roles/java-test-xdmp-login.json | Removes the now-unneeded role definition. |
| marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/TestBiTemporal.java | Stops creating a test role that includes xdmp-login. |
| marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestJSResourceExtensions.java | Stops creating a test role that includes xdmp-login. |
| marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestBulkWriteWithTransformations.java | Stops creating a test role that includes xdmp-login. |
| marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/datamovement/functionaltests/StringQueryHostBatcherTest.java | Stops creating a test role that includes xdmp-login. |
Comment on lines
1
to
+5
| { | ||
| "user-name": "rest-admin", | ||
| "description": "rest-admin user", | ||
| "role": ["rest-admin", "java-test-delete-temporal", "java-test-xdmp-login"], | ||
| "password": "x" | ||
| "user-name": "rest-admin", | ||
| "description": "rest-admin user", | ||
| "role": [ | ||
| "rest-admin", |
Comment on lines
1
to
+5
| { | ||
| "user-name": "rest-writer", | ||
| "description": "rest-writer user", | ||
| "role": ["rest-writer", "java-test-delete-graph", "java-test-xdmp-login"], | ||
| "password": "x" | ||
| "user-name": "rest-writer", | ||
| "description": "rest-writer user", | ||
| "role": [ | ||
| "rest-writer", |
Comment on lines
1
to
+5
| { | ||
| "user-name": "rest-evaluator", | ||
| "description": "Test user for the java-client-api-project", | ||
| "role": ["java-test-evaluator", "java-test-xdmp-login"], | ||
| "password": "x" | ||
| "user-name": "rest-evaluator", | ||
| "description": "Test user for the java-client-api-project", | ||
| "role": [ | ||
| "java-test-evaluator" |
Comment on lines
1
to
+5
| { | ||
| "user-name": "writer-no-default-permissions", | ||
| "description": "test user that does not have the rest-writer role so as to avoid having default permissions", | ||
| "role": [ | ||
| "test-rest-writer", | ||
| "java-test-delete-graph", | ||
| "rest-extension-user", | ||
| "rest-reader", | ||
| "java-test-xdmp-login" | ||
| ], | ||
| "password": "x" | ||
| "user-name": "writer-no-default-permissions", | ||
| "description": "test user that does not have the rest-writer role so as to avoid having default permissions", | ||
| "role": [ | ||
| "test-rest-writer", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on the server no longer requiring the xdmp-login privilege for using REST extensions or transforms.