Updated smoke tests#2573
Draft
robgruen wants to merge 26 commits into
Draft
Conversation
…osoft/TypeAgent into dev/robgruen/azure_pipeline
…ape, relaxed some of the phrasing for some unit tests
…ft/TypeAgent into dev/robgruen/fixed_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the test infrastructure and test data for the default agent provider, mainly focusing on normalizing URL comparisons in tests, refining test expectations, and improving test stability. The changes ensure that tests are less brittle in the face of minor output variations and that only the intended agents are evaluated during translation tests.
Test infrastructure improvements:
http:///https://forms as equivalent in test comparisons, reducing false negatives due to URL formatting differences (translateTestCommon.ts). [1] [2]utility) during translation tests to prevent them from interfering with the agents under test (translateTestCommon.ts). [1] [2] [3]Test data and expectation refinements:
anyofstructure, allow alternate phrasings, and remove unnecessary parameters (like"tab": "current"), making tests more flexible and realistic (translate-browser-e2e.json,translate-e2e.json,translate-history-e2e.json,translate-gate-e2e.json,translate-image-history-e2e.json). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]Workflow and CI stability:
Xvfbto prevent CI hangs by fully detaching its stdio and ensuring it is killed on exit (pipelines/azure-smoke-tests.yml).environment: development-forkassignment in the GitHub Actions workflow, possibly to restore conditional environment selection (.github/workflows/smoke-tests.yml).UI bugfix:
.conversation-name-barwould not be hidden when thehiddenattribute was set, by explicitly settingdisplay: none(chat.css).