Surface per-batch record count (param2) in HTTP response debug events#1487
Open
mogiligarimidi23 wants to merge 1 commit into
Open
Surface per-batch record count (param2) in HTTP response debug events#1487mogiligarimidi23 wants to merge 1 commit into
mogiligarimidi23 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Populates
evt.param2withctx->recordIdsAndTenantIds.size()acrossall 5 HTTP debug-event dispatch paths in
HttpResponseDecoder.cpp:EVT_HTTP_OK(successful upload)EVT_HTTP_ERROR(rejected by server)EVT_HTTP_FAILURE× 3 (no response, temporary server failure,temporary network failure)
Motivation
Debug event listeners currently receive the HTTP status code in
param1but have no way to know how many records were in the batch. This makes
it impossible to accurately count events delivered vs. dropped per HTTP
round-trip. The
EVT_REJECTEDpath already setsparam2; this changebrings the other paths to parity.
Impact
param2