You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Migrate native networking integration tests to either mock-based unit tests or implement networking endpoints in test website.
Type of Change
New feature (non-breaking change which adds functionality)
Why
Tests from class HttpOriginPolicyIntegrationTest, HttpResourceIntegrationTest, and WebSocketIntegrationTest use an in-process HTTP server which does not work well in the CI environment.
What
Convert tests in HttpOriginPolicyIntegrationTest into mock-based unit tests (no real HTTP server to interact with)
Move tests into existing unit test class OriginPolicyHttpFilterTest.
Delete test class HttpOriginPolicyIntegrationTest.
Rewrite test HTTP funcionality for HttpResourceIntegrationTest into the TestWebsite project.
Rewrite test WebSocket functionality for WebSocketIntegrationTest into the TestWebsite project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate native networking integration tests to either mock-based unit tests or implement networking endpoints in test website.
Type of Change
Why
Tests from class
HttpOriginPolicyIntegrationTest,HttpResourceIntegrationTest, andWebSocketIntegrationTestuse an in-process HTTP server which does not work well in the CI environment.What
HttpOriginPolicyIntegrationTestinto mock-based unit tests (no real HTTP server to interact with)OriginPolicyHttpFilterTest.HttpOriginPolicyIntegrationTest.HttpResourceIntegrationTestinto theTestWebsiteproject.WebSocketIntegrationTestinto theTestWebsiteproject.HttpServerandWebSocketServer.Testing
Microsoft Reviewers: Open in CodeFlow