Fix upload button rendering on top of text in comment input#8793
Merged
Conversation
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix upload file rendering on top of text in input
Fix upload button rendering on top of text in comment input
Jun 12, 2026
alexr00
approved these changes
Jun 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the comment input’s “Upload files” (cloud upload) button overlapping textarea content by removing its absolute positioning and letting it render as a normal flex item beneath the textarea in the existing column flex layout. This eliminates the need for the prior padding-bottom: 28px workaround on the textarea.
Changes:
- Removed
padding-bottom: 28pxfrom the comment textarea styles (both webviews). - Changed
.comment-upload-buttonfromposition: absolute(bottom-left overlay) toalign-self: flex-startwith margins so it flows below the textarea. - Kept the top-right
.title-actionabsolutely positioned (editor webview), relying on existingpadding-rightto avoid overlap.
Show a summary per file
| File | Description |
|---|---|
webviews/editorWebview/index.css |
Moves the upload button out of the textarea overlay and removes the textarea bottom-padding workaround while preserving the title-action overlay behavior. |
webviews/activityBarView/index.css |
Applies the same upload button layout change and removes the textarea bottom-padding workaround in the activity bar view. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
aeschli
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloud-upload button in the comment input was absolutely positioned over the textarea, causing it to overlap user-entered text. The previous
padding-bottom: 28pxworkaround only reserved space at the very end of the textarea content, so any wrapped or scrolled lines still rendered behind the button.Changes
webviews/editorWebview/index.css,webviews/activityBarView/index.css: dropposition: absoluteon.textarea-wrapper .comment-upload-buttonand let it flow as a flex row beneath the textarea (the wrapper is alreadyflex-direction: column). Remove the now-unnecessarypadding-bottom: 28pxon the textarea.The button now sits below the input anchored to the bottom-left, so it can no longer overlap text. The top-right
.title-action(sparkle/generate) remains absolutely positioned and is unaffected.