Skip to content

Attestation commit code review feedback from #8794#8804

Merged
alexr00 merged 1 commit into
mainfrom
alexr00/weekly-damselfly
Jun 19, 2026
Merged

Attestation commit code review feedback from #8794#8804
alexr00 merged 1 commit into
mainfrom
alexr00/weekly-damselfly

Conversation

@alexr00

@alexr00 alexr00 commented Jun 18, 2026

Copy link
Copy Markdown
Member

@alexr00 alexr00 self-assigned this Jun 18, 2026
@alexr00 alexr00 marked this pull request as ready for review June 19, 2026 12:49
Copilot AI review requested due to automatic review settings June 19, 2026 12:49
@alexr00 alexr00 enabled auto-merge (squash) June 19, 2026 12:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines how the PR timeline “New commits since your last review” marker is inserted, avoiding misleading markers when the only diverging commit predates the user’s latest review (e.g., an attestation commit), and aligns tests/documentation and a small caching initialization with that behavior.

Changes:

  • Skip inserting the NewCommitsSinceReview marker when there are no commits after the user’s most recent review.
  • Update the related unit test to assert that no marker is inserted in the pre-review-only diverging commit case.
  • Improve attestation commit signing detection by treating commit.gpgsign as a Git boolean (truthy values), and remove an unnecessary empty-array initialization for cached PR timeline events.
Show a summary per file
File Description
src/github/utils.ts Changes marker insertion logic to return early (no marker) when no post-review commits are present.
src/test/github/utils.test.ts Updates expectations to ensure no marker is inserted when the only diverging commit is pre-review.
src/issues/userCompletionProvider.ts Removes redundant initialization of cachedPrTimelineEvents to [], leaving it undefined until populated.
src/github/attestationCommit.ts Treats commit.gpgsign as a truthy Git boolean and updates inline documentation accordingly.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 0

@alexr00 alexr00 merged commit 18ea807 into main Jun 19, 2026
7 checks passed
@alexr00 alexr00 deleted the alexr00/weekly-damselfly branch June 19, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants