Attestation commit code review feedback from #8794#8804
Merged
Conversation
lszomoru
approved these changes
Jun 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines how the PR timeline “New commits since your last review” marker is inserted, avoiding misleading markers when the only diverging commit predates the user’s latest review (e.g., an attestation commit), and aligns tests/documentation and a small caching initialization with that behavior.
Changes:
- Skip inserting the
NewCommitsSinceReviewmarker when there are no commits after the user’s most recent review. - Update the related unit test to assert that no marker is inserted in the pre-review-only diverging commit case.
- Improve attestation commit signing detection by treating
commit.gpgsignas a Git boolean (truthy values), and remove an unnecessary empty-array initialization for cached PR timeline events.
Show a summary per file
| File | Description |
|---|---|
src/github/utils.ts |
Changes marker insertion logic to return early (no marker) when no post-review commits are present. |
src/test/github/utils.test.ts |
Updates expectations to ensure no marker is inserted when the only diverging commit is pre-review. |
src/issues/userCompletionProvider.ts |
Removes redundant initialization of cachedPrTimelineEvents to [], leaving it undefined until populated. |
src/github/attestationCommit.ts |
Treats commit.gpgsign as a truthy Git boolean and updates inline documentation accordingly. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
lszomoru
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8794