Skip to content

Strip nonadmin oadp 1.4#212

Open
NicholasYancey wants to merge 6 commits into
migtools:oadp-1.4from
NicholasYancey:strip-nonadmin-oadp-1.4
Open

Strip nonadmin oadp 1.4#212
NicholasYancey wants to merge 6 commits into
migtools:oadp-1.4from
NicholasYancey:strip-nonadmin-oadp-1.4

Conversation

@NicholasYancey

Copy link
Copy Markdown
Contributor

Why the changes were made

The OADP 1.4 operator does not ship the non-admin controller (RELATED_IMAGE_NON_ADMIN_CONTROLLER is absent from config/manager/manager.yaml on the oadp-1.4 branch, present on oadp-1.5). All non admin commands have been removed, along with the self service doc due to non admin not being supported in oadp-1.4. README and docs/OADP-1.4.md doc changes are handled separately in PR #210

How to test the changes made

  1. Build the binary: make build
  2. Verify non-admin commands are gone: ./kubectl-oadp --help should show no nonadmin or nabsl-request subcommands
  3. Verify admin commands still work: oc oadp backup --help, oc oadp restore --help, oc oadp schedule --help
  4. Run unit tests: make test

@NicholasYancey NicholasYancey self-assigned this Jun 30, 2026
@openshift-ci openshift-ci Bot requested a review from mpryc June 30, 2026 19:40
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NicholasYancey
Once this PR has been reviewed and has the lgtm label, please assign shawn-hurley for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3160185-7257-4544-bab3-3f64d43a2fe9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread cmd/setup/detector.go Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we even need admin detection?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe so, will edit files to align with no admin detection

@Joeavaikath

Copy link
Copy Markdown
Contributor

What a -10k nuke!
I really hope I didn't wire it in a way that makes this hard, sorry @NicholasYancey

@NicholasYancey NicholasYancey requested a review from kaovilai June 30, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants