Strip nonadmin oadp 1.4#212
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NicholasYancey The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
do we even need admin detection?
There was a problem hiding this comment.
I do not believe so, will edit files to align with no admin detection
|
What a -10k nuke! |
Why the changes were made
The OADP 1.4 operator does not ship the non-admin controller (RELATED_IMAGE_NON_ADMIN_CONTROLLER is absent from config/manager/manager.yaml on the oadp-1.4 branch, present on oadp-1.5). All non admin commands have been removed, along with the self service doc due to non admin not being supported in oadp-1.4. README and docs/OADP-1.4.md doc changes are handled separately in PR #210
How to test the changes made
make build./kubectl-oadp --helpshould show nononadminornabsl-requestsubcommandsoc oadp backup --help,oc oadp restore --help,oc oadp schedule --helpmake test