Skip to content

test: assert schedule, backup-location, must-gather, setup commands in root help#216

Open
Copilot wants to merge 2 commits into
oadp-devfrom
copilot/add-missing-assertions-to-testcommandarchitecture
Open

test: assert schedule, backup-location, must-gather, setup commands in root help#216
Copilot wants to merge 2 commits into
oadp-devfrom
copilot/add-missing-assertions-to-testcommandarchitecture

Conversation

Copilot AI commented Jul 1, 2026

Copy link
Copy Markdown

Why the changes were made

TestCommandArchitecture's "all major commands exist" subtest only asserted backup, restore, nabsl-request, nonadmin, client, and version in the root --help output. It omitted schedule, backup-location, must-gather, and setup, even though cmd/root.go registers all of them. The test therefore provided no coverage against accidental removal of those commands.

This mirrors the fix applied to oadp-1.4 in #212 and is the intended basis for cherry-pick to oadp-1.6 and oadp-1.5.

How to test the changes made

  • Extend the majorCommands slice in integration_test.go to include the four missing commands:
majorCommands := []string{"backup", "restore", "schedule", "backup-location", "nabsl-request", "nonadmin", "client", "must-gather", "setup", "version"}

Run the targeted subtest:

go test -run 'TestCommandArchitecture/all_major_commands_exist' .

Expected: ok github.com/migtools/oadp-cli.

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

Hi @Copilot. Thanks for your PR.

I'm waiting for a migtools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copilot AI changed the title [WIP] Add missing assertions for schedule, backup-location, must-gather, and setup test: assert schedule, backup-location, must-gather, setup commands in root help Jul 1, 2026
Copilot AI requested a review from kaovilai July 1, 2026 14:48
@kaovilai kaovilai marked this pull request as ready for review July 1, 2026 15:32
@openshift-ci openshift-ci Bot requested a review from mpryc July 1, 2026 15:32
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Copilot, kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integration_test.go: TestCommandArchitecture missing assertions for schedule, backup-location, must-gather, setup on main/oadp-1.6/oadp-1.5

2 participants