fix(client): respect session group capabilities#2861
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
2334d95 to
e729d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2689.
ClientSessionGroupwas querying prompts, resources, and tools on every connection, even when the server did not advertise those capabilities duringinitialize. For a tools-only server that meant two extra JSON-RPC calls that came back asMethod not foundwarnings.This changes
_aggregate_componentsto use negotiated capabilities when aninitialize_resultis available:list_prompts()whencapabilities.promptsis absentlist_resources()whencapabilities.resourcesis absentlist_tools()whencapabilities.toolsis absentI also added a regression test for a tools-only server session: it still aggregates the advertised tool, and
list_prompts/list_resourcesare not awaited.Validation: