fix: read instance attributes in api_bootstrapper_config#32
Merged
Conversation
The api_bootstrapper_config property built its LitestarConfig from the module-global settings singleton instead of self, so any Settings instance other than the singleton (or any access before the singleton is constructed) silently produced the singleton's values. Switch every field to self.*. Add a regression test that constructs a Settings with non-default service_name/service_version and asserts the config reflects the instance, not the global. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Settings.api_bootstrapper_configbuilt itsLitestarConfigfrom the module-globalsettingssingleton instead ofself:So any
Settingsinstance other than the singleton — or any access during the singleton's own construction — silently produced the singleton's values rather than its own.Fix
Every field now reads
self.*.Test (TDD — failing first)
Added
tests/test_settings.py, which constructs aSettings(service_name="custom-service", service_version="9.9.9")and assertsapi_bootstrapper_configreflects the instance.assert 'Litestar template' == 'custom-service'— fails, proving the global leak.20 passed, 100% coverage.
🤖 Generated with Claude Code