fix: added components tests to increase coverage to 80%#341
Open
ash-wright123 wants to merge 8 commits into
Open
fix: added components tests to increase coverage to 80%#341ash-wright123 wants to merge 8 commits into
ash-wright123 wants to merge 8 commits into
Conversation
ash-wright123
requested review from
Jameson13B,
codingLogan,
mwclemy and
wesrisenmay-mx
as code owners
mwclemy
reviewed
Jun 24, 2026
mwclemy
reviewed
Jun 24, 2026
mwclemy
reviewed
Jun 24, 2026
mwclemy
reviewed
Jun 24, 2026
| }) | ||
|
|
||
| const stepWrapper = container.firstChild | ||
| expect(stepWrapper).toBeInTheDocument() |
Collaborator
There was a problem hiding this comment.
How do we know for sure that stepWrapper corresponds to the Search view that was rendered? I think this could be improved by checking whether for example, the Select your institution text is rendered for the Search step. That would give us more confidence that the correct view is being displayed.
Similar comment for the other views as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.