Skip to content

nested spnmapping.md#1044

Open
brandonwest-netwrix wants to merge 18 commits into
devfrom
brandon-nwx-correct-page-naming
Open

nested spnmapping.md#1044
brandonwest-netwrix wants to merge 18 commits into
devfrom
brandon-nwx-correct-page-naming

Conversation

@brandonwest-netwrix

@brandonwest-netwrix brandonwest-netwrix commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Nested spnmapping.md under appletsettings.md for both versions 11.6 and 12.0.
Normalized page names.

Additional fixes from editorial review:

  • Added missing intro sentence in manualcertificate.md (11.6, 12.0)
  • Fixed broken Applet Settings link in proxymodeappletpermissions.md (12.0)
  • Fixed incomplete Applet Settings link in proxymodeservicepermissions.md (11.6, 12.0)
  • Capitalized sentence opener in recommended.md (11.6, 12.0)
  • Fixed typo "job froup" → "job group" in recommended.md (12.0)

brandonwest-netwrix and others added 2 commits May 29, 2026 10:37
…tsettings subdirectory for 11.6 and 12.0

Generated with AI

Co-Authored-By: Claude Code <ai@netwrix.com>
…pdate deps and fsaa docs

- Set rspackBundler and rspackPersistentCache to false in docusaurus.config.js to resolve
  webpack ProvidePlugin crash caused by docusaurus-plugin-openapi-docs incompatibility with rspack
- Update package.json and package-lock.json dependencies
- Update accessanalyzer 11.6 and 12.0 fsaa documentation content

Generated with AI

Co-Authored-By: Claude Code <ai@netwrix.com>
@brandonwest-netwrix brandonwest-netwrix requested a review from a team as a code owner June 1, 2026 17:49
…3.10.1

Take dev versions for preset-classic, theme-mermaid, and mdx-js/react (^3.10.1/^3.1.1)
and regenerate package-lock.json.

Generated with AI

Co-Authored-By: Claude Code <ai@netwrix.com>
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

101 issues fixed, 7 skipped across 18 files

Category Fixes
Contractions 36
Plurals 8
Removed filler 2
Substitutions 2
DesiredAsAdjective (rewrite) 4
FollowTheStepsTo (rewrite) 8
FormalHedging (rewrite) 7
Idioms (rewrite) 4
ImpersonalFiller (rewrite) 2
OxfordComma (rewrite) 4
Dale: idioms 2
Dale: passive-voice 12
Dale: positional-references 2
Dale: wordiness 8
Skipped (needs manual review) Reason
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive: 'US' here is the country abbreviation in 'US SSN' (United States Social Security Number), a product/criteria term, not the pronoun 'us'
docs/accessanalyzer/12.0/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive: 'US' here is the country abbreviation in 'US SSN' (United States Social Security Number), a product/criteria term, not the pronoun 'us'
docs/accessanalyzer/11.6/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md:46 — Dale: passive-voice Repeated pattern 'The following message is returned when the command completes successfully:' appears many times as parallel structure introducing console output; rewriting all occurrences would alter the documented expectation pattern
docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md:92 — Dale: passive-voice Conditional phrases 'If a communication timeout is reached' / 'is unchecked' / 'is checked' describe UI state — rewriting to active voice ('When you reach...' or 'When you clear...') changes who/what triggers the state and risks technical inaccuracy
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsaa_system_scans.md:111 — Dale: passive-voice Repeated parallel structure 'No warning will be shown' / 'A warning will be shown' appears in many nested list items as a documented behavior pattern; rewriting risks inconsistency across the parallel options
docs/accessanalyzer/11.6/solutions/filesystem/recommended.md:37 — Dale: passive-voice 'The host list assignment should be assigned under...' uses 'should be assigned' as documentation guidance; rewriting changes prescriptive tone (recommendation vs. instruction)
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsaa_system_scans.md:43 — Dale: passive-voice 'The 1-FSAA System Scans job has been preconfigured to run with the default settings' describes a product configuration state; rewriting to active voice would require identifying an agent that may not match the source intent

Ask @claude on this PR if you'd like an explanation of any fix.

v2.x of docusaurus-plugin-openapi-docs was incompatible with rspack,
causing a webpack ProvidePlugin crash. Upgrading to v5.0.2 (matching dev)
fixes the incompatibility, allowing rspack to be re-enabled. Without rspack
the webpack build OOMs on CI runners with limited memory.

Generated with AI

Co-Authored-By: Claude Code <ai@netwrix.com>
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

37 issues fixed, 9 skipped across 22 files

Category Fixes
Contractions 2
Plurals 2
CanBeUsedTo (rewrite) 2
FirstPerson (rewrite) 4
FormalHedging (rewrite) 6
Idioms (rewrite) 4
OnceUsage (rewrite) 2
QuestionHeadings (rewrite) 4
Dale: passive-voice 5
Dale: positional-references 2
Dale: wordiness 4
Skipped (needs manual review) Reason
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive — 'US' here is the country code in 'US SSN' (United States Social Security Number), a Sensitive Data Discovery criterion name, not first-person plural
docs/accessanalyzer/12.0/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive — 'US' here is the country code in 'US SSN' (United States Social Security Number), a Sensitive Data Discovery criterion name, not first-person plural
docs/accessanalyzer/11.6/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md:45 — Dale: passive-voice 'The following message is returned when the command completes successfully' is a standard CLI documentation convention; rewriting to active would be unnatural and could change reader expectations across the entire step-by-step procedure (appears repeatedly).
docs/accessanalyzer/12.0/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md:44 — Dale: passive-voice Same repeated CLI convention as above; rewriting would alter standard procedure phrasing and may obscure that the message is the command's output, not the user's action.
docs/accessanalyzer/11.6/solutions/filesystem/recommended.md:132 — Dale: wordiness 'Whatever schedule frequency may be configured, it is also recommended to streamline the collection jobs to those desired' — rewriting to active form requires either first person ('we recommend', forbidden) or imperative, which would change a recommendation into a directive and alter authorial intent.
docs/accessanalyzer/11.6/solutions/filesystem/recommended.md:145 — Dale: wordiness 'It isn't recommended to delete any jobs' — same as above; converting to imperative ('Don't delete any jobs') strengthens the guidance from recommendation to instruction, changing meaning.
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/asaservice/proxymodeservicepermissions.md:35 — Dale: passive-voice 'It is recommended to use the same domain account' — same issue: converting to imperative changes recommendation strength; no first-person alternative permitted.
docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md:89 — Dale: passive-voice 'after the timeout value has been exceeded' — passive but standard technical phrasing for describing event timing; active alternatives ('after the timeout elapses') change technical nuance.
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsaa_system_scans.md:110 — Dale: wordiness 'which include but aren't limited to' is mildly wordy but standard legal/technical hedge phrasing; alternatives risk implying the list is exhaustive when the author explicitly intends otherwise.

Ask @claude on this PR if you'd like an explanation of any fix.

@brandonwest-netwrix

Copy link
Copy Markdown
Collaborator Author

@netwrix/accessanalyzer-docs please review - this is a page re-org only

- Add intro sentence before :::note in manualcertificate.md (11.6, 12.0)
- Fix broken Applet Settings link in proxymodeappletpermissions.md (12.0)
- Fix incomplete Applet Settings link in proxymodeservicepermissions.md (11.6, 12.0)
- Capitalize sentence opener in filesystem recommended.md (11.6, 12.0)
- Fix typo "job froup" → "job group" in recommended.md (12.0)

Generated with AI

Co-Authored-By: Claude Code <ai@netwrix.com>
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

6 issues fixed, 10 skipped across 22 files

Category Fixes
Dale: passive-voice 2
Dale: positional-references 2
Dale: wordiness 2
Skipped (needs manual review) Reason
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive — 'US' here is the country abbreviation in 'US SSN' (United States Social Security Number), not the first person plural pronoun. Rewriting would change the meaning.
docs/accessanalyzer/12.0/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive — 'US' here is the country abbreviation in 'US SSN' (United States Social Security Number), not the first person plural pronoun. Rewriting would change the meaning.
docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md:105 — Dale: passive-voice 'When checked, this option will timeout the applet' — fixing would require introducing a subject; ambiguity about whether 'checked' refers to user or option made the rewrite risky.
docs/accessanalyzer/11.6/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md:24 — Dale: passive-voice 'All files that are generated by the Certificate Manager or copied to the Enterprise Auditor console are placed in...' — multiple agents (tool vs. user) make active rewrite ambiguous.
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/asaservice/proxymodeservicepermissions.md:35 — Dale: passive-voice 'It is recommended to use the same domain account...' — changing to imperative would alter the recommendation tone into a directive.
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/withapplet/proxymodeappletpermissions.md:32 — Dale: wordiness 'require .NET Framework 4.7.2 or later to be installed on the server where the applet is to be deployed in order for Sensitive Data Discovery collections to successfully occur' — wholesale rewrite would risk meaning change.
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsaa_system_scans.md:116 — Dale: passive-voice Repeated 'A warning will be shown' patterns — high risk of meaning drift across many similar lines.
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-seek_system_scans.md:191 — Dale: undefined-acronyms 'SDD' used in body without local definition; the page is titled around sensitive data and SDD appears in section headings — ambiguous whether body use needs separate definition.
docs/accessanalyzer/11.6/solutions/filesystem/recommended.md:289 — Dale: undefined-acronyms 'AIC Active Directory Exceptions reports' — uncertain what AIC stands for in this product context.
docs/accessanalyzer/12.0/admin/datacollector/fsaa/appletsettings/spnmapping.md:78 — Dale: passive-voice 'Access Analyzer will use the SPN...' uses future tense rather than passive; style preference but not a clear Dale violation.

Ask @claude on this PR if you'd like an explanation of any fix.

@brandonwest-netwrix

Copy link
Copy Markdown
Collaborator Author

@netwrix/accessanalyzer-docs ready for review and merge

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

20 issues fixed, 18 skipped across 22 files

Category Fixes
FollowTheStepsTo (rewrite) 2
Dale: passive-voice 18
Skipped (needs manual review) Reason
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive. 'US' in 'US SSN' refers to United States Social Security Number — it is part of a product-defined System Criteria name (alongside Credit Cards, Passwords, Tax Forms), not the first person plural pronoun. Rewriting would alter a literal UI/product label.
docs/accessanalyzer/12.0/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive. 'US' in 'US SSN' refers to United States Social Security Number — it is part of a product-defined System Criteria name (alongside Credit Cards, Passwords, Tax Forms), not the first person plural pronoun. Rewriting would alter a literal UI/product label.
docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md:105 — Dale: passive-voice 'When checked, this option will timeout the applet...' - rewriting risked changing the meaning of the conditional logic
docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md:91 — Dale: passive-voice 'after the timeout value has been exceeded' - common technical phrasing; active alternatives like 'after exceeding' could obscure which actor exceeds the value
docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md:117 — Dale: passive-voice 'all certificates to be valid and in their respective stores beforehand' - infinitive construction is idiomatic in this context
docs/accessanalyzer/11.6/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md:22 — Dale: passive-voice 'files that are generated by the Certificate Manager or copied to the Enterprise Auditor console are placed in' - rewriting would require choosing one of two subjects (Certificate Manager vs. user) and could change meaning
docs/accessanalyzer/11.6/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md:25 — Dale: passive-voice 'files are placed into the root' - subject of who places the files is ambiguous
docs/accessanalyzer/11.6/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md:45 — Dale: passive-voice 'The following message is returned when the command completes successfully' - common output description; repeats throughout and rewriting all instances risks inconsistency
docs/accessanalyzer/11.6/admin/datacollector/fsaa/overview.md:35 — Dale: passive-voice 'The Sensitive Data Discovery Add-On must be installed on the Enterprise Auditor Console server' - active rewrite would require choosing the actor (you, an admin) which could shift the meaning of a prerequisite statement
docs/accessanalyzer/11.6/admin/datacollector/fsaa/updateservicesettings.md:22 — Dale: passive-voice 'When selected, this option will timeout the applet if there is an attempt to pause the scan' - rewriting risked changing the meaning of the conditional logic
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/asaservice/proxymodeservicepermissions.md:11 — Dale: passive-voice 'File System Proxy Service installation package must be installed on the Windows proxy servers' - part of a definitional list item; active rewrite could shift it from definition to instruction
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/asaservice/proxymodeservicepermissions.md:35 — Dale: passive-voice 'It is recommended to use the same domain account' - rewriting to active would require first-person 'we recommend' which violates style guide
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/withapplet/proxymodeappletpermissions.md:9 — Dale: passive-voice 'When File System scans are run in proxy mode with applet, it means the File System applet is deployed' - heavy nested passives; safe active rewrite would significantly restructure the sentence
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/withapplet/proxymodeappletpermissions.md:17 — Dale: passive-voice 'This is required by either the user account running the Access Analyzer application, when manually executing jobs within the console, or the Schedule Service Account' - complex disjunction; restructuring risks changing which permission scenarios are listed
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsaa_system_scans.md:42 — Dale: passive-voice 'The 1-FSAA System Scans job has been preconfigured to run' - 'preconfigured' is a state descriptor and rewriting could obscure that it's a pre-existing condition
docs/accessanalyzer/11.6/solutions/filesystem/recommended.md:98 — Dale: passive-voice 'The Connection Profile should be assigned under the FileSystem > 0.Collection job's Properties window' - 'should' carries normative weight; converting to imperative changes the strength of the recommendation
docs/accessanalyzer/11.6/solutions/filesystem/recommended.md:145 — Dale: passive-voice 'It isn't recommended to delete any jobs' - active alternative requires first-person 'we don't recommend' which violates the style guide
docs/accessanalyzer/12.0/admin/datacollector/fsaa/appletsettings/appletsettings.md:104 — Dale: passive-voice 'When checked, this option will timeout the applet...' - rewriting risked changing the meaning of the conditional logic

Ask @claude on this PR if you'd like an explanation of any fix.

brandonwest-netwrix and others added 2 commits June 4, 2026 11:23
Restores package.json and package-lock.json to dev state, removing
unintended Docusaurus plugin downgrades and serve upgrade that were
unrelated to the page naming changes in this PR.

Generated with AI

Co-Authored-By: Claude Code <ai@netwrix.com>
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

10 issues fixed, 8 skipped across 22 files

Category Fixes
OnceUsage (rewrite) 2
Dale: passive-voice 8
Skipped (needs manual review) Reason
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural 'US' here is the country acronym (United States) in the literal product UI label 'US SSN' — a preconfigured System Criteria option in AccessAnalyzer. Not first person plural; changing the label could break alignment with the product UI.
docs/accessanalyzer/12.0/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural 'US' here is the country acronym (United States) in the literal product UI label 'US SSN' — a preconfigured System Criteria option in AccessAnalyzer. Not first person plural; changing the label could break alignment with the product UI.
docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md:91 — Dale: passive-voice 'after the timeout value has been exceeded' — converting to active would require introducing an ambiguous subject; the agent of the timeout exceed is unclear
docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md:132 — Dale: idioms 'sits behind a proxy' is metaphorical but standard, widely-understood technical phrasing
docs/accessanalyzer/11.6/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md:45 — Dale: passive-voice 'The following message is returned' is a repeated structural construction across many steps; rewriting risks inconsistency and changes the focus from message to command
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsaa_system_scans.md:114 — Dale: passive-voice Repeated 'will be shown' / 'will not be shown' construction in a long parallel list; rewriting all instances risks breaking parallel structure
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/withapplet/proxymodeappletpermissions.md:9 — Dale: wordiness 'it means the File System applet is deployed' — fix requires introducing a subject (Access Analyzer / Enterprise Auditor) and ambiguity over which is correct for each version
docs/accessanalyzer/12.0/admin/datacollector/fsaa/appletsettings/spnmapping.md:11 — Dale: idioms 'sits behind a proxy' is metaphorical but standard, widely-understood technical phrasing

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions

Copy link
Copy Markdown
Contributor

Documentation PR Review

Editorial Review

This PR is primarily a mechanical style pass (contractions, active voice, present tense, "prior to" → "before", removing "designed to"/"in order to") plus a structural reorganization that moves appletsettings.md and spnmapping.md into an appletsettings/ subfolder. The reorganization is sound: the new _category_.json files are consistent across both versions, and every cross-reference to the old appletsettings.md/spnmapping.md paths was updated to the new locations. The heading rewrites (for example, "How do I determine if I'm using Proxy Mode…?" → "Verify Proxy Mode with Service scanning") correctly convert question headings into imperative task headings per the style guide.

Only two minor items across the 22 changed files:

docs/accessanalyzer/11.6/solutions/filesystem/recommended.md

  • Clarity — Line ~646 (added): "Windows clusters have special needs for the host list and host inventory data." "special needs" reads colloquially for reference documentation. Suggested fix: "Windows clusters have specific requirements for the host list and host inventory data."
  • Clarity — Line ~764 (added): "The Ad Hoc Audits Job Group works independently from the rest of the solution…" The standard construction is "independently of." Suggested fix: "…works independently of the rest of the solution but depends on the 0.Collection Job Group."

docs/accessanalyzer/12.0/solutions/filesystem/recommended.md

  • Clarity — Added line: "Windows clusters have special needs for the host list and host inventory data." Same as 11.6. Suggested fix: "Windows clusters have specific requirements for the host list and host inventory data."
  • Clarity — Added line: "The Ad Hoc Audits Job Group works independently from the rest of the solution…" Suggested fix: "…works independently of the rest of the solution but depends on the 0.Collection Job Group."

All other files — No issues found:

  • docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/appletsettings.md
  • docs/accessanalyzer/11.6/admin/datacollector/fsaa/appletsettings/spnmapping.md
  • docs/accessanalyzer/11.6/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md
  • docs/accessanalyzer/11.6/admin/datacollector/fsaa/overview.md
  • docs/accessanalyzer/11.6/admin/datacollector/fsaa/updateservicesettings.md
  • docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/asaservice/proxymodeservicepermissions.md
  • docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/withapplet/proxymodeappletpermissions.md
  • docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsaa_system_scans.md
  • docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsac_system_scans.md
  • docs/accessanalyzer/11.6/solutions/filesystem/collection/1-seek_system_scans.md
  • docs/accessanalyzer/12.0/admin/datacollector/fsaa/appletsettings/appletsettings.md
  • docs/accessanalyzer/12.0/admin/datacollector/fsaa/appletsettings/spnmapping.md
  • docs/accessanalyzer/12.0/admin/datacollector/fsaa/certificatemanagement/manualcertificate.md
  • docs/accessanalyzer/12.0/admin/datacollector/fsaa/overview.md
  • docs/accessanalyzer/12.0/admin/datacollector/fsaa/updateservicesettings.md
  • docs/accessanalyzer/12.0/requirements/filesystem/scanoptions/proxy-mode-scans/as-a-service/proxymodeservicepermissions.md
  • docs/accessanalyzer/12.0/requirements/filesystem/scanoptions/proxy-mode-scans/with-applet/proxymodeappletpermissions.md
  • docs/accessanalyzer/12.0/solutions/filesystem/collection/1-fsaa_system_scans.md
  • docs/accessanalyzer/12.0/solutions/filesystem/collection/1-fsac_system_scans.md
  • docs/accessanalyzer/12.0/solutions/filesystem/collection/1-seek_system_scans.md

Summary

4 editorial suggestions across 2 files (the two recommended.md files share the same two issues). The structural reorganization and cross-reference updates are consistent and correct. Vale and Dale issues are auto-fixed separately.


What to do next:

Comment @claude on this PR followed by your instructions to get help:

  • @claude fix all issues — fix all editorial issues
  • @claude help improve the flow of this document — get writing assistance
  • @claude explain the voice issues — understand why something was flagged

You can ask Claude anything about the review or about Netwrix writing standards.

Automated fixes are only available for branches in this repository, not forks.

@github-actions

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

43 issues fixed, 6 skipped across 22 files

Category Fixes
Dale: passive-voice 43
Skipped (needs manual review) Reason
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive. 'US' in 'US SSN' is the country abbreviation for United States (US Social Security Number), a System Criteria label in the SDD settings — not the first-person plural pronoun 'us'. Rewriting would corrupt a product configuration label.
docs/accessanalyzer/12.0/solutions/filesystem/collection/1-seek_system_scans.md:49 — Netwrix.FirstPersonPlural False positive. 'US' in 'US SSN' is the country abbreviation for United States (US Social Security Number), a System Criteria label in the SDD settings — not the first-person plural pronoun 'us'. Rewriting would corrupt a product configuration label.
docs/accessanalyzer/11.6/solutions/filesystem/recommended.md:309 — Dale: undefined-acronyms 'AIC' is a product-specific acronym used without definition, but the correct full form could not be confirmed from context, so expanding it could introduce an inaccuracy
docs/accessanalyzer/12.0/solutions/filesystem/recommended.md:299 — Dale: undefined-acronyms 'AIC' is a product-specific acronym used without definition, but the correct full form could not be confirmed from context, so expanding it could introduce an inaccuracy
docs/accessanalyzer/11.6/requirements/filesystem/scanoptions/proxymodescans/withapplet/proxymodeappletpermissions.md:9 — Dale: passive-voice null
docs/accessanalyzer/11.6/solutions/filesystem/collection/1-fsaa_system_scans.md:120 — Dale: passive-voice null

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions

Copy link
Copy Markdown
Contributor

Code Review

Reviewed for correctness, build/routing, scripts, and workflows (documentation content/style intentionally skipped). The only non-docs change is .gitignore; everything else is a file reorganization plus prose edits.

🔴 .gitignore now ignores package.json and package-lock.json

+package.json
+package-lock.json

Both files are currently tracked (git ls-files confirms), so git keeps versioning them and CI (npm ci) is not broken today. However, adding them to .gitignore is almost certainly unintentional and is a real footgun:

  • Future dependency changes (npm install bumping a version, a lockfile refresh) will not be staged by git add / git add . — they silently drop out, requiring git add -f. This leads to dependency drift between local, CI, and production over time.
  • These are among the most important files to keep tracked in a Node project.

This looks like it was added to hide a local uncommitted change to those files. Recommend removing both lines unless there is a deliberate reason (in which case it should be documented).

🟡 Page moves change public URLs with no redirects

appletsettings.md and spnmapping.md were moved into a new appletsettings/ folder:

  • /fsaa/appletsettings/fsaa/appletsettings/appletsettings
  • /fsaa/spnmapping/fsaa/appletsettings/spnmapping

(for both 11.6 and 12.0)

Build is fine — I verified all internal .md links and absolute docs.netwrix.com links were updated to the new paths, and grepped the repo for any lingering references to the old paths (fsaa/appletsettings.md, fsaa/spnmapping, URL forms) — none remain, so onBrokenLinks: 'throw' will pass. The new _category_.json (link.id: "appletsettings") mirrors the existing, working certificatemanagement/ pattern and resolves correctly.

The only downside: the old URLs will now 404 for external bookmarks, search-engine results, and any deep links from outside this repo. The plugin-client-redirects config only handles base-product→latest-version redirects, not these page moves. If preserving those inbound links matters, consider adding client redirects for the two old paths.

✅ Checked, no issues

  • No changes to products.js, docusaurus.config.js, sidebars, KB copy scripts, or GitHub Actions workflows.
  • _category_.json files are valid JSON (missing trailing newline is cosmetic).
  • Sidebar reorg (spnmapping nested under appletsettings) is structurally sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants