ci: hold Renovate PRs until packages pass sfw minimumReleaseAge#825
Conversation
CI runs `sfw vp install`, which enforces pnpm's minimumReleaseAge cooldown. Renovate opened update PRs immediately on release, so the lockfile failed the supply-chain policy check with ERR_PNPM_MINIMUM_RELEASE_AGE_VIOLATION. Add minimumReleaseAge: "3 days" for all npm packages so updates age past the cooldown before a PR opens, and keep "0 days" for the vite-plus group since those are already in minimumReleaseAgeExclude.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ChangesRenovate Config Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration in renovate.json by setting a minimum release age of 3 days for npm packages and 0 days for the vite-plus group. The reviewer suggested using glob patterns for package name matching to simplify the configuration and ensure future packages from the same scopes are automatically included.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #825 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 10 10
Lines 747 747
Branches 235 235
=======================================
Hits 709 709
Misses 35 35
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adjusts Renovate configuration to reduce CI failures caused by Socket Firewall Free (sfw vp install) enforcing pnpm’s minimumReleaseAge cooldown, by delaying most npm updates while allowing the Vite+ toolchain to update immediately.
Changes:
- Add a Renovate
packageRulesentry applyingminimumReleaseAge: "3 days"to all npm datasource updates. - Set
minimumReleaseAge: "0 days"for thevite-plusgrouped dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "groupName": "vite-plus", | ||
| "matchPackageNames": [ | ||
| "vite-plus", | ||
| "@voidzero-dev/vite-plus-core", | ||
| "@voidzero-dev/vite-plus-test", |
Problem
Renovate PRs fail at the Setup Vite+ step because CI runs
sfw vp install(Socket Firewall Free), which enforces pnpm'sminimumReleaseAgecooldown. Renovate opens update PRs the moment a version is published, so the lockfile fails the supply-chain policy check:Seen on the undici 8.4.1 -> 8.5.0 PR (#824).
Fix
minimumReleaseAge: "3 days"for all npm packages, so updates age past the sfw cooldown before a PR opens.minimumReleaseAge: "0 days"for the vite-plus group, which is already inminimumReleaseAgeExcludeinpnpm-workspace.yamland can update immediately.Values mirror voidzero's
Boshen/renovatepreset used with the same sfw setup.Summary by CodeRabbit