Skip to content

perf(health-report): skip codebase metrics in base snapshot#63

Merged
aspala merged 1 commit into
mainfrom
perf/base-snapshot-skip-codebase-metrics
Jun 7, 2026
Merged

perf(health-report): skip codebase metrics in base snapshot#63
aspala merged 1 commit into
mainfrom
perf/base-snapshot-skip-codebase-metrics

Conversation

@aspala

@aspala aspala commented Jun 7, 2026

Copy link
Copy Markdown
Member

Was

Der base-snapshot überspringt jetzt auch run_codebase_metrics (skip_codebase_metrics opt).

Warum

#61 (v1.7) entfernte die LOO aus dem base-snapshot. Ein beobachteter v1.8-Lauf auf product-db (714 Files, PR #282) verbrachte dort aber immer noch ~6min. Telemetrie hat's festgenagelt: der base-snapshot fuhr weiter run_codebase_metrics — dominiert von near_duplicate_blocks_codebase, das O(Files²)-artig ist (17,9s allein für 373 Files → bei 714 quadratisch ~6min).

Wie schon die LOO-Nodes ist dieser Output ungelesen: codebase-metrics sitzen neben dem aggregate, und der base-snapshot speist nur Delta.compute, das ausschließlich ['codebase']['aggregate'] liest.

Korrektheit (bewiesen, nicht angenommen)

analyze_codebase(compute_nodes: false) mit und ohne skip liefert eine byte-gleiche ['codebase']['aggregate'] auf position-db/lib — nur die ungelesenen near_duplicate/similarity-Keys fallen weg. Verifiziert per direktem Vergleich.

Messung (lokal gegen die echte position-db, 714 base-Files)

  • base-snapshot Analyse-Phase: ~6min → ~24s
  • aggregate identisch → Metric-Changes-Delta unverändert
  • 921 Tests grün, Credo strict clean

Kontext

Dritter und letzter base-snapshot-Posten nach #60 (base-ref scoping) und #61 (LOO skip). Der base-snapshot baut jetzt nur noch das, was der Delta wirklich liest.

After #61 removed leave-one-out from the base snapshot, an observed v1.8 run on
a 714-file repo still spent ~6min there. Telemetry pinned it: the base snapshot
was running run_codebase_metrics — dominated by near_duplicate_blocks_codebase,
which is O(files^2)-ish (17.9s for 373 files alone). Like the LOO nodes, that
output is never read: codebase metrics sit beside the aggregate, and the base
snapshot feeds only Delta.compute, which reads ['codebase']['aggregate'].

Add a skip_codebase_metrics opt and set it for the base snapshot. The aggregate
(all the delta needs) is still built from every file.

Proven identical: analyze_codebase(compute_nodes: false) with and without the
skip yields a byte-equal ['codebase']['aggregate'] on position-db/lib; only the
unread near_duplicate/similarity keys drop.

Measured locally against the real position-db (714 base files): the base
snapshot's analyze phase dropped from ~6min to ~24s. 921 tests green.
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Score: C+ → C+ | Δ -1 pts | 0 blocks flagged across 2 files | 2 modified, 0 added

🟠 Code Health: C+ (63/100)

192 files · codeqa-action · 2026-06-07

Combined metric scores use cosine similarity: +1 = metric profile perfectly matches healthy pattern for this behavior, 0 = no signal, −1 = anti-pattern detected. Mapped to 0–100 using breakpoints (approx: ≥0.5→A, ≥0.2→B, ≥0.0→C, ≥−0.3→D, <−0.3→F); actual letter grades use the full 15-step scale.

Metric Changes

Category Base Head Δ
Readability 88.27 97.81 +9.55
Complexity 30.59 41.25 +10.66
Duplication 0.57 0.59 +0.02
Structure 6.19 9.03 +2.84
%%{init: {'theme': 'neutral'}}%%
xychart-beta
    title "Code Health Scores"
    x-axis ["Readability", "Complexity", "Structure", "Duplication", "Naming", "Magic Numbers", "Combined Metrics"]
    y-axis "Score" 0 --> 100
    bar [94, 31, 88, 48, 96, 100, 65]
Loading
Readability       ███████████████████░   94  🟢 A
Complexity        ██████░░░░░░░░░░░░░░   31  🔴 D-
Structure         ██████████████████░░   88  🟢 A-
Duplication       ██████████░░░░░░░░░░   48  🟠 C-
Naming            ███████████████████░   96  🟢 A
Magic Numbers     ████████████████████  100  🟢 A
Combined Metrics  █████████████░░░░░░░   65  🔴 D

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor
🔍 Top Likely Issues (cosine similarity)

Most negative cosine = file's metric profile best matches this anti-pattern.

Behavior Cosine Score
dependencies.low_coupling -0.56 -12.49
file_structure.single_responsibility -0.51 -12.31
file_structure.line_count_under_300 -0.44 -9.42
code_smells.no_dead_code_after_return -0.42 -33.91
scope_and_assignment.used_only_once -0.42 -14.65
scope_and_assignment.shadowed_by_inner_scope -0.34 -4.91
file_structure.line_length_under_120 -0.30 -8.33
scope_and_assignment.declared_close_to_use -0.26 -1.60
code_smells.no_debug_print_statements -0.24 -2.25
variable_naming.loop_var_is_single_letter -0.23 3.54
🟢 Readability — A (94/100)

Codebase averages: flesch_adapted=97.81, fog_adapted=4.82, avg_tokens_per_line=9.53, avg_line_length=35.74

Metric Value Score
readability.flesch_adapted 97.81 100
readability.fog_adapted 4.82 100
readability.avg_tokens_per_line 9.53 72
readability.avg_line_length 35.74 100
🔴 Complexity — D- (31/100)

Codebase averages: difficulty=41.25, effort=235309.34, volume=4053.68, estimated_bugs=1.35

Metric Value Score
halstead.difficulty 41.25 42
halstead.effort 235309.34 0
halstead.volume 4053.68 46
halstead.estimated_bugs 1.35 46
🟢 Structure — A- (88/100)

Codebase averages: branching_density=0.14, mean_depth=3.86, avg_function_lines=8.30, max_depth=9.21, max_function_lines=19.95, variance=6.85, avg_param_count=1.16, max_param_count=2.05

Metric Value Score
branching.branching_density 0.14 76
indentation.mean_depth 3.86 88
function_metrics.avg_function_lines 8.30 89
indentation.max_depth 9.21 87
function_metrics.max_function_lines 19.95 100
indentation.variance 6.85 100
function_metrics.avg_param_count 1.16 100
function_metrics.max_param_count 2.05 100
🟠 Duplication — C- (48/100)

Codebase averages: redundancy=0.59, bigram_repetition_rate=0.54, trigram_repetition_rate=0.37

Metric Value Score
compression.redundancy 0.59 58
ngram.bigram_repetition_rate 0.54 38
ngram.trigram_repetition_rate 0.37 40
🟢 Naming — A (96/100)

Codebase averages: entropy=0.89, mean=6.65, variance=18.83, avg_sub_words_per_id=1.17

Metric Value Score
casing_entropy.entropy 0.89 100
identifier_length_variance.mean 6.65 100
identifier_length_variance.variance 18.83 85
readability.avg_sub_words_per_id 1.17 100
🟢 Magic Numbers — A (100/100)

Codebase averages: density=0.00

Metric Value Score
magic_number_density.density 0.00 100
🔴 Combined Metrics — D (65/100)
Category Score Grade
Code Smells 25 🔴 D-
Consistency 81 🟡 B+
Dependencies 19 🔴 E+
Documentation 83 🟡 B+
Error Handling 92 🟢 A-
File Structure 48 🟠 C-
Function Design 81 🟡 B+
Naming Conventions 90 🟢 A-
Scope And Assignment 28 🔴 D-
Testing 83 🟡 B+
Type And Value 89 🟢 A-
Variable Naming 74 🟡 B
🔴 Code Smells — D- (25/100)

Cosine similarity scores for 1 behaviors.

Behavior Cosine Score Grade
no_dead_code_after_return -0.42 25 D-
🟡 Consistency — B+ (81/100)

Cosine similarity scores for 1 behaviors.

Behavior Cosine Score Grade
consistent_function_style 0.37 81 B+
🔴 Dependencies — E+ (19/100)

Cosine similarity scores for 1 behaviors.

Behavior Cosine Score Grade
low_coupling -0.56 19 E+
🟡 Documentation — B+ (83/100)

Cosine similarity scores for 3 behaviors.

Behavior Cosine Score Grade
file_has_module_docstring 0.30 77 B
function_has_docstring 0.45 86 A-
docstring_is_nonempty 0.45 87 A-
🟢 Error Handling — A- (92/100)

Cosine similarity scores for 3 behaviors.

Behavior Cosine Score Grade
error_message_is_descriptive 0.52 90 A-
does_not_swallow_errors 0.60 92 A-
returns_typed_error 0.69 94 A
🟠 File Structure — C- (48/100)

Cosine similarity scores for 5 behaviors.

Behavior Cosine Score Grade
single_responsibility -0.51 21 E+
line_count_under_300 -0.44 24 E+
line_length_under_120 -0.30 30 D-
has_consistent_indentation 0.26 74 B
no_magic_numbers 0.57 91 A-
🟡 Function Design — B+ (81/100)

Cosine similarity scores for 3 behaviors.

Behavior Cosine Score Grade
is_less_than_20_lines 0.33 79 B+
no_magic_numbers 0.38 82 B+
has_verb_in_name 0.40 83 B+
🟢 Naming Conventions — A- (90/100)

Cosine similarity scores for 1 behaviors.

Behavior Cosine Score Grade
function_name_is_not_single_word 0.50 90 A-
🔴 Scope And Assignment — D- (28/100)

Cosine similarity scores for 3 behaviors.

Behavior Cosine Score Grade
used_only_once -0.42 25 D-
shadowed_by_inner_scope -0.34 28 D-
declared_close_to_use -0.26 32 D-
🟡 Testing — B+ (83/100)

Cosine similarity scores for 2 behaviors.

Behavior Cosine Score Grade
test_single_concept 0.27 74 B
test_name_describes_behavior 0.53 91 A-
🟢 Type And Value — A- (89/100)

Cosine similarity scores for 1 behaviors.

Behavior Cosine Score Grade
hardcoded_url_or_path 0.49 89 A-
🟡 Variable Naming — B (74/100)

Cosine similarity scores for 1 behaviors.

Behavior Cosine Score Grade
name_is_generic 0.26 74 B

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

kind: refactoring-tasks
path: /home/runner/work/codeqa-action/codeqa-action
timestamp: 2026-06-07T12:15:26.132943Z
overall_grade: C+
overall_score: 63
task_count: 0
critical: 0
high: 0
instructions: >-
Address the tasks below in order of severity (critical first).
After each fix, run the project's test suite and confirm it passes
before moving on.

No critical or high-severity blocks need attention. ✅

@aspala aspala merged commit 0a486f5 into main Jun 7, 2026
8 checks passed
@aspala aspala deleted the perf/base-snapshot-skip-codebase-metrics branch June 7, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant