Add aarch64-unknown-linux-musl target#232
Conversation
frejsoya
force-pushed
the
add-aarch64-linux-musl
branch
from
ebc522e to
0b09c50
Compare
frejsoya
force-pushed
the
add-aarch64-linux-musl
branch
2 times, most recently
from
5af543d to
aaa51df
Compare
frejsoya
force-pushed
the
add-aarch64-linux-musl
branch
from
aaa51df to
b42b022
Compare
Leonidas-from-XIV
requested review from
Leonidas-from-XIV,
Sudha247 and
shonfeder
|
Good to see you, @frejsoya! We had an issue with the formatting but if you rebase your PR then that should work again. Can you do a run on your fork to show that the ARM64 binary on Linux is successfully passing the test? It will fail to upload to our infrastructure but it would be good seeing that the produced binary is working. |
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This looks OK to me, but I am not an expert on this set up.
I agree @Leonidas-from-XIV requests should be addressed before we merge.
We build static musl Dune binaries for x86_64 but not ARM64, so anyone on Graviton, Ampere, or an Apple Silicon Linux VM is stuck building from source. This adds the same static build for ARM64, running natively on the ubuntu-22.04-arm runner. Signed-off-by: Frej Soya <frej.soya@gmail.com> Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
add-aarch64-linux-musl
branch
from
b42b022 to
52317f9
Compare
Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
I've forked and tested the action on my repo and somehow Nix fails to build the OCaml compiler because it can't find a C compiler, despite installing and detecting GCC 15.2. Weird.
|
Ok, it seems like it is installing the |
|
Turns out that the current way of building static binaries via Nix in Dune does not work on arm64, one needs to use a different toolchain than the However even with that change there's some flags missing and the resulting binary ends up not being a static binary, some more investigation and fixes are needed. Given this is not my highest priority at the moment (lower than #237) I'll stop the investigation here for now. Picking it up at a later point in time should be pretty easy however. |
4 participants
Static dune binaries (musl) for ARM64 Linux.