Fix Verilog top module detection for modules with a parameter block#313
Open
hendrikmennen with Copilot wants to merge 2 commits into
Open
Fix Verilog top module detection for modules with a parameter block#313hendrikmennen with Copilot wants to merge 2 commits into
hendrikmennen with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: hendrikmennen <25281882+hendrikmennen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix top module detection for Verilog modules with parameter blocks
Fix Verilog top module detection for modules with a parameter block
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Verilog module declared with a parameter block (
#( ... )) before its port list was not recognized as a top module.VerilogNodeProvider.ParseModulesconsumed the balanced parameter block but did not skip whitespace before expecting the port-list(, so any newline/space between)and(caused the module to be misclassified as portless and dropped.Changes
src/OneWare.Verilog/Parsing/VerilogNodeProvider.cs): skip whitespace after the#( ... )parameter block before matching the port-list(.internal staticstring-based helpers (ExtractNodes,ExtractTopEntities) so parsing can be tested on raw source without constructing anIProjectFile. The public file-based API is unchanged.tests/OneWare.Verilog.UnitTestsproject (added toOneWare.slnx, wired viaInternalsVisibleTo) covering parameterized modules with and without whitespace before the port list, plain modules, and port extraction.